fix build_llvm.py not to regard a dir as an executable file in which() #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
tmikov
approved these changes
Jul 12, 2019
There was a problem hiding this comment.
@tmikov has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 28, 2019
Summary: Used in 3 places (more soon), and this is more readable. Pull Request resolved: facebookincubator/fbjni#21 Test Plan: CI Reviewed By: cjhopman Differential Revision: D18138398 Pulled By: dreiss fbshipit-source-id: 70b2a0a88ae278da3d0076fc62f6fb582001ef57
Closed
1 task
2 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my environment, there's
cmakedirectory in the PATH andwhich()found it as an executable file and the build script fails.