Test Additions for JS Array Functions #31
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…type.keys() functions.
facebook-github-bot
added
the
CLA Signed
avp
requested changes
Jul 13, 2019
There was a problem hiding this comment.
Adding tests is always helpful, thanks!
We already have some array iteration tests in
https://github.com/facebook/hermes/blob/master/test/hermes/iterator.js
though, so it would be preferred if you could move any tests for array iteration there instead.
|
Thanks @avp! I have added tests to the |
avp
approved these changes
Jul 15, 2019
There was a problem hiding this comment.
@avp is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
facebook-github-bot
pushed a commit
that referenced
this pull request
Jan 14, 2020
Summary: ## Motivation Why are you making this change? What did you change? How does the code work? Why did you choose this approach? Pull Request resolved: facebookincubator/fbjni#31 Test Plan: How did you test this change? Any change that adds functionality should add a unit test as well. Reviewed By: BurntBrunch Differential Revision: D19348810 Pulled By: passy fbshipit-source-id: 7a144c80cc1078d968a562a17fa8d5f84047eeb2
Closed
1 task
2 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Hermes VM currently has support for Javascript's
Array.prototype.values()andArray.prototype.keys()functions but tests for them were yet to be included.I worked on tests for both functions in this pull request.