New benchmark: string-switch #955
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D44617123 |
Summary: Pull Request resolved: facebook#955 Benchmark to compare fundamental performance of mapping from a string key, using an Object, a Map or a `switch` with a string argument. Proposed by sebmarkbage. Initial performance results on MPB PRO x86-64 are interesting, showing that we have more fundamental work to do: | | shermes | hermes | v8 | v8 --jitless | jsc | jsc --useJIT=0 | |--------|--------:|-------:|----:|-------------:|----:|---------------:| | Switch | 4997 | 5450 | 267 | 2912 | 250 | 1095 | | Object | 658 | 793 | 274 | 825 | 224 | 1150 | | Map | 874 | 965 | 185 | 783 | 276 | 1131 | Reviewed By: avp Differential Revision: D44617123 fbshipit-source-id: 08067c753d25fd5e15ae2e9e15aa425a1d01b128
|
This pull request was exported from Phabricator. Differential Revision: D44617123 |
tmikov
force-pushed
the
export-D44617123-to-static_h
branch
from
2ffb364
to
44402ee
Compare
facebook-github-bot
pushed a commit
that referenced
this pull request
Apr 3, 2023
Summary: Pull Request resolved: #955 Benchmark to compare fundamental performance of mapping from a string key, using an Object, a Map or a `switch` with a string argument. Proposed by sebmarkbage. Initial performance results on MPB PRO x86-64 are interesting, showing that we have more fundamental work to do: | | shermes | hermes | v8 | v8 --jitless | jsc | jsc --useJIT=0 | |--------|--------:|-------:|----:|-------------:|----:|---------------:| | Switch | 4997 | 5450 | 267 | 2912 | 250 | 1095 | | Object | 658 | 793 | 274 | 825 | 224 | 1150 | | Map | 874 | 965 | 185 | 783 | 276 | 1131 | Reviewed By: avp Differential Revision: D44617123 fbshipit-source-id: bfcd506e388703e9e88be45474c2c4b837cf5e95
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Benchmark to compare fundamental performance of mapping from a string
key, using an Object, a Map or a
switchwith a string argument.Proposed by sebmarkbage.
Initial performance results on MPB PRO x86-64 are interesting, showing
that we have more fundamental work to do:
Differential Revision: D44617123