Skip to content

Commit

Permalink
Split Futures exceptions by Promise vs Future
Browse files Browse the repository at this point in the history
Summary:
[Folly] Split Futures exceptions by `Promise` vs `Future`.

* Move `Promise` exceptions into the `Promise` header.
* Move `Future` exceptions into the `Future` header.
* Split `NoState` into `PromiseInvalid` and `FutureInvalid`.
* Remove the newly-empty exceptions header.

Reviewed By: andriigrynenko

Differential Revision: D7966499

fbshipit-source-id: 2dc6d2a941493979ebf47b3e70e5cf6a6fbd33cf
  • Loading branch information
yfeldblum authored and hhvm-bot committed May 19, 2018
1 parent e6c628c commit 1416e7f
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion hphp/runtime/ext/watchman/ext_watchman.cpp
Expand Up @@ -433,7 +433,7 @@ struct ActiveSubscription {
auto res_future = promise.getFuture();
if (timeout != std::chrono::milliseconds::zero()) {
res_future = res_future.within(timeout)
.onError([](folly::TimedOut) {
.onError([](folly::FutureTimeout) {
return false;
});
}
Expand Down

0 comments on commit 1416e7f

Please sign in to comment.