Default forward_static_call to a fatal

Summary:
`forward_static_call` has it's defaults set to a warning here: [D13424056].

This defaults `forward_static_call` to a fatal.

Tests that were explicitly testing the behaviour of `forward_static_call` and `forward_static_call_array` have been removed. While other tests that used them have been updated.

Reviewed By: ricklavoie

Differential Revision: D13938319

fbshipit-source-id: bd89af64b4f4109b02288fb69892ff548711478f

hphp/runtime/base/runtime-option.cpp

@@ -696,8 +696,8 @@ int64_t RuntimeOption::HeapLowWaterMark = 16;
 int64_t RuntimeOption::HeapHighWaterMark = 1024;
 
 uint64_t RuntimeOption::DisableExtract = 0;
-uint64_t RuntimeOption::DisableForwardStaticCall = 1;
-uint64_t RuntimeOption::DisableForwardStaticCallArray = 1;
+uint64_t RuntimeOption::DisableForwardStaticCall = 2;
+uint64_t RuntimeOption::DisableForwardStaticCallArray = 2;
 uint64_t RuntimeOption::DisableCallUserFunc = 0;
 uint64_t RuntimeOption::DisableCallUserFuncArray = 0;
 uint64_t RuntimeOption::DisableParseStrSingleArg = 0;

hphp/test/quick/fsc02.php

@@ -13,7 +13,6 @@ public function f1() {
 class C extends B {
   public function g() {
     $obj = new B;
-    forward_static_call(array('B', 'f1'));
     call_user_func(array('B', 'f1'));
   }
 }

hphp/test/quick/fsc02.php.expectf

@@ -1,7 +1,2 @@
-Warning: forward_static_call() is deprecated and subject to removal from the Hack language in %s on line 16
 string(1) "C"
 string(1) "C"
-
-string(1) "C"
-string(1) "C"
-

hphp/test/slow/dynamic-calls/forbid-notice.php

@@ -26,12 +26,6 @@ public static function positive_test1() {
     try { parent::$x(); } catch (Exception $e) { wrap($e); }
   }
 
-  public static function positive_test2() {
-    try { forward_static_call('C::foobar'); } catch (Exception $e) { wrap($e); }
-    try { forward_static_call(['C', 'foobar']); } catch (Exception $e) { wrap($e); }
-    try { forward_static_call([new C, 'foobar']); } catch (Exception $e) { wrap($e); }
-  }
-
   public static function negative_test1() {
     self::foobar();
     static::foobar();
@@ -53,9 +47,6 @@ public static function negative_test1() {
     self::$x();
     static::$x();
     parent::$x();
-    forward_static_call('E::foobar');
-    forward_static_call(['E', 'foobar']);
-    forward_static_call([new E, 'foobar']);
   }
 }
 
@@ -128,24 +119,6 @@ public static function static_cmp($x, $y) { return $x <=> $y; }
     try { await parent::$x(); } catch (Exception $e) { wrap($e); }
   }
 
-  public static function positive_test2() {
-    try { forward_static_call('func'); } catch (Exception $e) { wrap($e); }
-    try { forward_static_call('A::func'); } catch (Exception $e) { wrap($e); }
-    try { forward_static_call('A::static_func'); } catch (Exception $e) { wrap($e); }
-    try { forward_static_call(['A', 'func']); } catch (Exception $e) { wrap($e); }
-    try { forward_static_call(['A', 'static_func']); } catch (Exception $e) { wrap($e); }
-    try { forward_static_call([new A, 'func']); } catch (Exception $e) { wrap($e); }
-    try { forward_static_call([new A, 'static_func']); } catch (Exception $e) { wrap($e); }
-
-    try { forward_static_call_array('func', []); } catch (Exception $e) { wrap($e); }
-    try { forward_static_call_array('A::func', []); } catch (Exception $e) { wrap($e); }
-    try { forward_static_call_array('A::static_func', []); } catch (Exception $e) { wrap($e); }
-    try { forward_static_call_array(['A', 'func'], []); } catch (Exception $e) { wrap($e); }
-    try { forward_static_call_array(['A', 'static_func'], []); } catch (Exception $e) { wrap($e); }
-    try { forward_static_call_array([new A, 'func'], []); } catch (Exception $e) { wrap($e); }
-    try { forward_static_call_array([new A, 'static_func'], []); } catch (Exception $e) { wrap($e); }
-  }
-
   public static async function negative_test1() {
     self::func();
     static::func();
@@ -167,9 +140,6 @@ public static function positive_test2() {
     new static;
     new parent;
 
-    forward_static_call('count', []);
-    forward_static_call_array('count', [[]]);
-
     $x = 'func2';
     self::$x();
     static::$x();
@@ -190,21 +160,6 @@ public static function positive_test2() {
     await static::$x();
     await parent::$x();
 
-    forward_static_call('func2');
-    forward_static_call('A::func2');
-    forward_static_call('A::static_func2');
-    forward_static_call(['A', 'func2']);
-    forward_static_call(['A', 'static_func2']);
-    forward_static_call([new A, 'func2']);
-    forward_static_call([new A, 'static_func2']);
-
-    forward_static_call_array('func2', []);
-    forward_static_call_array('A::func2', []);
-    forward_static_call_array('A::static_func2', []);
-    forward_static_call_array(['A', 'func2'], []);
-    forward_static_call_array(['A', 'static_func2'], []);
-    forward_static_call_array([new A, 'func2'], []);
-    forward_static_call_array([new A, 'static_func2'], []);
   }
 }
 
@@ -293,9 +248,6 @@ class F extends A {
   try { call_user_func_array([new A, 'func'], []); } catch (Exception $e) { wrap($e); }
   try { call_user_func_array([new A, 'static_func'], []); } catch (Exception $e) { wrap($e); }
 
-  A::positive_test2();
-  C::positive_test2();
-
   try { $x = 'cmp'; $y = [2, 1]; usort(&$y, $x); } catch (Exception $e) { wrap($e); }
   try { $x = 'A::cmp'; $y = [2, 1]; usort(&$y, $x); } catch (Exception $e) { wrap($e); }
   try { $x = 'A::static_cmp'; $y = [2, 1]; usort(&$y, $x); } catch (Exception $e) { wrap($e); }