Match PHP's use strict; easter egg and add one of our own

Summary: It's all fun and games... Closes #4556 Reviewed By: @fredemmott Differential Revision: D1860928
facebook · Feb 20, 2015 · 55eb45f · 55eb45f · Majkl578 · Feb 20, 2015
1 parent fb09e0d
commit 55eb45f
Show file tree

Hide file tree

Showing 5 changed files with 21 additions and 0 deletions.
diff --git a/hphp/compiler/parser/parser.cpp b/hphp/compiler/parser/parser.cpp
@@ -2418,6 +2418,15 @@ void Parser::onNamespaceEnd() {
 }
 
 void Parser::onUse(const std::string &ns, const std::string &as) {
+  if (ns == "strict") {
+    if (m_scanner.isHHSyntaxEnabled()) {
+      error("To use strict hack, place // strict after the open tag. "
+            "If it's already there, remove this line. "
+            "Hack is strict already.");
+    }
+    error("You seem to be trying to use a different language. "
+          "May I recommend Hack? http://hacklang.org");
+  }
   string key = fully_qualified_name_as_alias_key(ns, as);
 
   // It's not an error if the alias already exists but is auto-imported.

diff --git a/hphp/test/slow/parser/use-strict-hack.php b/hphp/test/slow/parser/use-strict-hack.php
@@ -0,0 +1,5 @@
+<?hh
+
+use strict;
+
+echo "Done";
diff --git a/hphp/test/slow/parser/use-strict-hack.php.expectf b/hphp/test/slow/parser/use-strict-hack.php.expectf
@@ -0,0 +1 @@
+Fatal error: To use strict hack, place // strict after the open tag. If it's already there, remove this line. Hack is strict already. in %s/test/slow/parser/use-strict-hack.php on line 3
diff --git a/hphp/test/slow/parser/use-strict.php b/hphp/test/slow/parser/use-strict.php
@@ -0,0 +1,5 @@
+<?php
+
+use strict;
+
+echo "Done";
diff --git a/hphp/test/slow/parser/use-strict.php.expectf b/hphp/test/slow/parser/use-strict.php.expectf
@@ -0,0 +1 @@
+Fatal error: You seem to be trying to use a different language. May I recommend Hack? http://hacklang.org in %s/test/slow/parser/use-strict.php on line 3