Skip to content

Commit

Permalink
Updating coding-conventions.md in deference to our new struct overlords
Browse files Browse the repository at this point in the history
Summary: All hail!

Reviewed By: Orvid

Differential Revision: D2912893

fb-gh-sync-id: c26a4dcc61ccfdc0c61240315c4dd101e522ce4a
shipit-source-id: c26a4dcc61ccfdc0c61240315c4dd101e522ce4a
  • Loading branch information
mxw authored and hhvm-bot committed Feb 16, 2016
1 parent 5d7bf0f commit 70bee86
Showing 1 changed file with 5 additions and 2 deletions.
7 changes: 5 additions & 2 deletions hphp/doc/coding-conventions.md
Expand Up @@ -151,8 +151,11 @@ In C++, `struct` and `class` have nearly identical meanings; the only
difference lies in the default accessibility (`struct` defaults to public, and
`class`, to private).
We do not assign further meaning to these keywords, so using `struct`
everywhere is a common (but not required) practice.
We do not assign further meaning to these keywords, so we use `struct`
everywhere. Efforts to compile under MSVC also require that we use the same
keyword between a struct/class definition and its forward declarations due to
MSVC's failure to adhere to the C++ spec, and sticking to `struct` everywhere
makes this easier.
### Access control ###
Expand Down

0 comments on commit 70bee86

Please sign in to comment.