Allow exceptions in ServerInit hooks

Summary: because some hooks may throw. Reviewed By: kodafb Differential Revision: D3899629 fbshipit-source-id: 0d673d211e31bb2fc552ec7d6da340eb70ac5865
facebook · Sep 27, 2016 · a55135e · a55135e
1 parent 219505b
commit a55135e
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/hphp/runtime/server/http-server.cpp b/hphp/runtime/server/http-server.cpp
@@ -283,7 +283,13 @@ void HttpServer::runOrExitProcess() {
     Logger::Info("debugger server started");
   }
 
-  InitFiniNode::ServerInit();
+  try {
+    InitFiniNode::ServerInit();
+  } catch (std::exception &e) {
+    startupFailure(
+      folly::sformat("Exception in InitFiniNode::ServerInit(): {}",
+                     e.what()));
+  }
 
   {
     BootStats::mark("servers started");