Skip to content

Commit

Permalink
Fix native function name after adding namespace
Browse files Browse the repository at this point in the history
Summary: Forgot to update registered function names after adding namespace.

Reviewed By: markw65

Differential Revision: D2945409

fb-gh-sync-id: 77c843e95e8461b8ce23a8348c15feedbbc0327d
shipit-source-id: 77c843e95e8461b8ce23a8348c15feedbbc0327d
  • Loading branch information
binliu19 authored and hhvm-bot committed Feb 18, 2016
1 parent 502d56f commit e8e9acc
Show file tree
Hide file tree
Showing 4 changed files with 14 additions and 3 deletions.
4 changes: 2 additions & 2 deletions hphp/runtime/ext/server/ext_server.cpp
Expand Up @@ -56,8 +56,8 @@ static struct ServerExtension final : Extension {
HHVM_FE(xbox_set_thread_timeout);
HHVM_FE(xbox_schedule_thread_reset);
HHVM_FE(xbox_get_thread_time);
HHVM_FE(server_is_stopping);
HHVM_FE(server_uptime);
HHVM_FALIAS(HH\\server_is_stopping, server_is_stopping);
HHVM_FALIAS(HH\\server_uptime, server_uptime);

loadSystemlib();
}
Expand Down
7 changes: 7 additions & 0 deletions hphp/test/server/http/server_root/test_status.php
@@ -0,0 +1,7 @@
<?php

$uptime = HH\server_uptime();
var_dump($uptime);

$stopping = HH\server_is_stopping();
var_dump($stopping);
1 change: 1 addition & 0 deletions hphp/test/server/http/tests/runTest1.php
Expand Up @@ -3,6 +3,7 @@
require_once('test_base.inc');

requestAll(array(
"test_status.php",
"test_get.php?name=Foo",
"test_get.php?name=Bar",
"apc_apache_note.php",
Expand Down
5 changes: 4 additions & 1 deletion hphp/test/server/http/tests/runTest1.php.expectf
@@ -1,3 +1,6 @@
Requesting 'test_status.php'
string(%d) "int(%d)
bool(false)"
Requesting 'test_get.php?name=Foo'
string(15) "string(3) "Foo""
Requesting 'test_get.php?name=Bar'
Expand Down Expand Up @@ -71,4 +74,4 @@ array(5) {
}
}"
Requesting 'test_curl_multi_except.php'
string(%d) "Hello, World!%d:::Exception: oops"
string(%d) "Hello, World!%d:::Exception: oops"

0 comments on commit e8e9acc

Please sign in to comment.