Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test suite] problem symlink #1064

Closed
ellisium opened this issue Sep 17, 2013 · 4 comments
Closed

[test suite] problem symlink #1064

ellisium opened this issue Sep 17, 2013 · 4 comments

Comments

@ellisium
Copy link

test/run all
458 tests failed

Problems:
1/datetime diff
2/locale diff
3/%s diff abs path
4/no line at end of file this one is the most frequent zend tests. files affected are
link (broken) (inode/symlink)

I'm missing to set some options or something else?
bcs seems I'm only one who encounter this problem

@scannell
Copy link
Contributor

Did you mean to post something else? All I see is:

link (broken) (inode/symlink)

#3, %s matches different paths. If you're seeing that, it means something else failed in the test. #4 might also be the same thing.

Datetime and locale settings could affect the relevant tests. Do you see other tests failing? (Try on Ubuntu 12.04, if possible?)

@ellisium
Copy link
Author

Hi. my config is
vista pro+virtualbox 4.2.16 running ubuntu 12.04 and latest HHVM (ddl this morning)

#1 exemple PM vs AM
test/slow/ext_date/1776.php
--- test/slow/ext_date/1776.php.expect 2013-09-16 20:43:44.000000000 +0200
+++ test/slow/ext_date/1776.php.out 2013-09-17 17:02:45.180849066 +0200
@@ -3,4 +3,4 @@
string(0) ""
string(1) "@"
bool(false)
-string(2) "PM"
+string(2) "AM"

#2 exemple en_US vs en_US_POSIX
test/slow/ext_collator/1810.php
--- test/slow/ext_collator/1810.php.expect 2013-09-16 20:43:44.000000000 +0200
+++ test/slow/ext_collator/1810.php.out 2013-09-17 17:02:43.764866866 +0200
@@ -510,7 +510,7 @@
Locale: 'uk-ua_CALIFORNIA@currency=;currency=GRN'
ULOC_VALID_LOCALE = 'uk_UA'
Locale: ''

  • ULOC_VALID_LOCALE = 'en_US'
  • ULOC_VALID_LOCALE = 'en_US_POSIX'

#3 exemple:
-HipHop Warning: Invalid argument: Charset parameter exceeds the maximum allowed length of 64 characters in %s/test/slow/invalid_argument/1381.php on line 8
+HipHop Warning: Invalid argument: Charset parameter exceeds the maximum allowed length of 64 characters in /home/ellisium/prog/hhvm/hiphop-php/hphp/test/slow/invalid_argument/1381.php on line 8

test expect %s/test/... but output is absolute path /home/ellisium/prog/hhvm/hiphop-php/hphp/test/...

#4 symlink broken File could not be loaded exemple
sorry screenshot is in french = link (broken) (inode/symlink)
capture du 2013-09-17 17_11_20

test/zend/good/ext-curl/bug62839.php
--- test/zend/good/ext-curl/bug62839.php.expectf 2013-09-16 20:43:44.000000000 +0200
+++ test/zend/good/ext-curl/bug62839.php.out 2013-09-17 17:05:53.766478211 +0200
@@ -1 +1 @@
-DONE!
\ Pas de fin de ligne à la fin du fichier
+HipHop Notice: File could not be loaded: test/zend/good/ext-curl/bug62839.php

Have so many test failing, it's difficult to note all. when #4 will be fixed, I can check more easily

@scannell
Copy link
Contributor

The first two categories are config related, I think, and probably not an issue.

Re: (3), what I am saying is those warning lines being different, as long as there is a %s in them, are not a problem -- they won't trigger a warning alone as %s will match the path. [We know the paths are different, the %s is intended to replace it. See the README file in hphp/test for more information.] There's something else in that test that is failing...

Re: (4), sorry, I can't read that, and I can't put it into a translator either since it's in a screenshot...

@ellisium
Copy link
Author

about #4
exemple : test/zend/good/ext-curl/bug62839.php is not a normal file.
that's a symlink. and my system indicates me it's broken symlink.
So test is not performed and output +HipHop Notice: File could not be loaded: test/zend/good/ext-curl/bug62839.php

ok finally I've found. about #4 that's a problem when extracting archive files... some files are transformed in symlink. Really odd.

For 1-2-3 it's ok, I can check that manually

facebook-github-bot pushed a commit that referenced this issue Oct 12, 2022
Summary:
This is needed for fmt 9+. [1]

This fixes a build failure seen while building Watchman 2022.10.10 for Homebrew at Homebrew/homebrew-core#112788 (against fmt 9.1.0). Without this, the build fails with

      /opt/homebrew/include/fmt/format.h:3973:30: error: no matching member function for call to 'format'
        out = value_formatter_.format(map(*it), ctx);
              ~~~~~~~~~~~~~~~~~^~~~~~

Full build logs available [2]. Errors for the arm64 Monterey runner start at [3].

[1] https://fmt.dev/9.0.0/api.html#formatting-user-defined-types
[2] https://github.com/Homebrew/homebrew-core/actions/runs/3220853975
[3] https://github.com/Homebrew/homebrew-core/actions/runs/3220853975/jobs/5276286644#step:6:704

X-link: facebook/watchman#1064

Reviewed By: chadaustin

Differential Revision: D40313845

Pulled By: xavierd

fbshipit-source-id: 5783a8273b8b09984f2e14e55cf2406517e9d8b9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants