compile error HPHP::Variant::Variant(ssize_t) cannot be overloaded #16

danielrmz · 2010-02-21T00:36:28Z

I ran make and get the following error.

[ 17%] Building CXX object src/CMakeFiles/hphp_runtime_static.dir/cpp/base/string_data.cpp.o
In file included from /home/daniel/workspace/hiphop-php/src/cpp/base/zend/zend_string.h:22,
from /home/daniel/workspace/hiphop-php/src/cpp/base/string_data.cpp:22:
/home/daniel/workspace/hiphop-php/src/cpp/base/type_variant.h:95: error: ‘HPHP::Variant::Variant(ssize_t)’ cannot be overloaded
/home/daniel/workspace/hiphop-php/src/cpp/base/type_variant.h:92: error: with ‘HPHP::Variant::Variant(int)’
make[2]: *** [src/CMakeFiles/hphp_runtime_static.dir/cpp/base/string_data.cpp.o] Error 1
make[1]: *** [src/CMakeFiles/hphp_runtime_static.dir/all] Error 2

The text was updated successfully, but these errors were encountered:

Maeyanie · 2010-02-21T08:19:44Z

This happens on some 32-bit platforms, where ssize_t is a typedef of an int.
It seems to work if "ssize_t" is replaced with "long" in all appropriate places.

scottmac · 2010-02-21T09:20:29Z

We only support 64-bit for now.

@jdelong

We had a bug where a PHP program can infinitely recurse in a certain way that doesn't hit any of our native stack overflow checks and causes the process to segfault. Below I've included a snippet of the callstack that caused HHVM to crash. The fix is to make invokeFunc(), invokeFuncFew(), and invokeContFunc() unconditionally perform a stack overflow check for the native stack. I tried to keep the fix minimal and non-invasive so that we can get this hotfixed if needed. #0 0x00000000032ba2ef in malloc () #1 0x000000000257401e in HPHP::Util::canonicalize(char const*, unsigned long, bool) () #2 0x0000000001c15f0e in HPHP::resolve_include(HPHP::String const&, char const*, bool (*)(HPHP::String const&, void*), void*) () #3 0x0000000001bd0327 in HPHP::Eval::resolveVmInclude(HPHP::StringData*, char const*, stat*) () #4 0x0000000001fe47d0 in HPHP::VMExecutionContext::lookupPhpFile(HPHP::StringData*, char const*, bool*) () #5 0x0000000001fe521a in HPHP::VMExecutionContext::evalInclude(HPHP::StringData*, HPHP::StringData const*, bool*) () #6 0x0000000001c17231 in HPHP::AutoloadHandler::Result HPHP::AutoloadHandler::loadFromMap<HPHP::ConstantExistsChecker>(HPHP::String const&, HPHP::String const&, bool, HPHP::ConstantExistsChecker const&) () #7 0x0000000001c174ed in HPHP::AutoloadHandler::autoloadConstant(HPHP::StringData*) () #8 0x00000000020c1c73 in HPHP::Unit::loadCns(HPHP::StringData const*) () #9 0x0000000001f1d10e in HPHP::Transl::lookupCnsHelper(HPHP::TypedValue const*, HPHP::StringData*, bool) () #10 0x000000002827f855 in ?? () #11 0x00000000026e566e in enterTCHelper () #12 0x0000000001f35ef0 in HPHP::Transl::TranslatorX64::enterTC(unsigned char*, void*) () #13 0x0000000002018004 in HPHP::VMExecutionContext::enterVM(HPHP::TypedValue*, HPHP::ActRec*) () #14 0x000000000201821c in HPHP::VMExecutionContext::reenterVM(HPHP::TypedValue*, HPHP::ActRec*, HPHP::TypedValue*) () #15 0x0000000002018612 in HPHP::VMExecutionContext::invokeFunc(HPHP::TypedValue*, HPHP::Func const*, HPHP::Array const&, HPHP::ObjectData*, HPHP::Class*, HPHP::VarEnv*, HPHP::StringData*, HPHP::VMExecutionContext::InvokeFlags) () #16 0x0000000001c146d0 in HPHP::vm_call_user_func(HPHP::Variant const&, HPHP::Array const&, bool) () #17 0x0000000001c17107 in HPHP::AutoloadHandler::Result HPHP::AutoloadHandler::loadFromMap<HPHP::ConstantExistsChecker>(HPHP::String const&, HPHP::String const&, bool, HPHP::ConstantExistsChecker const&) () #18 0x0000000001c174ed in HPHP::AutoloadHandler::autoloadConstant(HPHP::StringData*) () #19 0x00000000020c1c73 in HPHP::Unit::loadCns(HPHP::StringData const*) () #20 0x0000000001f1d10e in HPHP::Transl::lookupCnsHelper(HPHP::TypedValue const*, HPHP::StringData*, bool) () #21 0x000000002827f855 in ?? () #22 0x00000000026e566e in enterTCHelper () #23 0x0000000001f35ef0 in HPHP::Transl::TranslatorX64::enterTC(unsigned char*, void*) () #24 0x0000000002018004 in HPHP::VMExecutionContext::enterVM(HPHP::TypedValue*, HPHP::ActRec*) () ... #28992 0x0000000001c174ed in HPHP::AutoloadHandler::autoloadConstant(HPHP::StringData*) () #28993 0x00000000020c1c73 in HPHP::Unit::loadCns(HPHP::StringData const*) () #28994 0x0000000001f1d10e in HPHP::Transl::lookupCnsHelper(HPHP::TypedValue const*, HPHP::StringData*, bool) () #28995 0x000000002827f855 in ?? () #28996 0x00000000026e566e in enterTCHelper () #28997 0x0000000001f35ef0 in HPHP::Transl::TranslatorX64::enterTC(unsigned char*, void*) () #28998 0x0000000002018004 in HPHP::VMExecutionContext::enterVM(HPHP::TypedValue*, HPHP::ActRec*) () #28999 0x000000000201821c in HPHP::VMExecutionContext::reenterVM(HPHP::TypedValue*, HPHP::ActRec*, HPHP::TypedValue*) () #29000 0x0000000002018612 in HPHP::VMExecutionContext::invokeFunc(HPHP::TypedValue*, HPHP::Func const*, HPHP::Array const&, HPHP::ObjectData*, HPHP::Class*, HPHP::VarEnv*, HPHP::StringData*, HPHP::VMExecutionContext::InvokeFlags) () #29001 0x0000000001c146d0 in HPHP::vm_call_user_func(HPHP::Variant const&, HPHP::Array const&, bool) () #29002 0x0000000001c17676 in HPHP::AutoloadHandler::Result HPHP::AutoloadHandler::loadFromMap<HPHP::ClassExistsChecker>(HPHP::String const&, HPHP::String const&, bool, HPHP::ClassExistsChecker const&) () #29003 0x0000000001c17a57 in HPHP::AutoloadHandler::invokeHandler(HPHP::String const&, bool) () #29004 0x00000000020cb504 in HPHP::Unit::loadClass(HPHP::NamedEntity const*, HPHP::StringData const*) () #29005 0x000000000203247e in void HPHP::VMExecutionContext::dispatchImpl<2>(int) () #29006 0x000000000203ef43 in HPHP::VMExecutionContext::dispatchBB() () #29007 0x0000000001f35f70 in HPHP::Transl::TranslatorX64::enterTC(unsigned char*, void*) () #29008 0x0000000002017ed7 in HPHP::VMExecutionContext::enterVM(HPHP::TypedValue*, HPHP::ActRec*) () #29009 0x000000000201888d in HPHP::VMExecutionContext::invokeFunc(HPHP::TypedValue*, HPHP::Func const*, HPHP::Array const&, HPHP::ObjectData*, HPHP::Class*, HPHP::VarEnv*, HPHP::StringData*, HPHP::VMExecutionContext::InvokeFlags) () #29010 0x0000000002018ea0 in HPHP::VMExecutionContext::invokeUnit(HPHP::TypedValue*, HPHP::Unit*) () #29011 0x0000000001c15964 in HPHP::invoke_file(HPHP::String const&, bool, char const*) () #29012 0x0000000001c19a52 in HPHP::include_impl_invoke(HPHP::String const&, bool, char const*) () #29013 0x0000000001c5d883 in HPHP::hphp_invoke(HPHP::ExecutionContext*, std::basic_fbstring<char, std::char_traits<char>, std::allocator<char>, std::fbstring_core<char> > const&, bool, HPHP::Array const&, HPHP::VRefParamValue const&, std::basic_fbstring<char, std::char_traits<char>, std::allocator<char>, std::fbstring_core<char> > const&, std::basic_fbstring<char, std::char_traits<char>, std::allocator<char>, std::fbstring_core<char> > const&, bool&, std::basic_fbstring<char, std::char_traits<char>, std::allocator<char>, std::fbstring_core<char> >&, bool, bool, bool) () #29014 0x0000000001b2659e in HPHP::RPCRequestHandler::executePHPFunction(HPHP::Transport*, HPHP::SourceRootInfo&, HPHP::RPCRequestHandler::ReturnEncodeType) () #29015 0x0000000001b285d3 in HPHP::RPCRequestHandler::handleRequest(HPHP::Transport*) () #29016 0x0000000001b6b85b in HPHP::XboxWorker::doJob(HPHP::XboxTransport*) () #29017 0x0000000001b669a3 in HPHP::JobQueueWorker<HPHP::XboxTransport*, HPHP::Server*, true, false, HPHP::JobQueueDropVMStack>::start() () #29018 0x000000000252c127 in HPHP::AsyncFuncImpl::ThreadFunc(void*) () #29019 0x00007f1ce3787f88 in start_thread (arg=0x7f1c377ff700) Reviewed By: @jdelong Differential Revision: D1052293

Summary: This brings forward some of the changes in vixl which has to do with the disassembly of the loadStoreExclusive Aarch64 instructions. It was noticed that some instructions where not disassembled correctly when examining the output from TRACE=printir:9 Before ==== 478 (03) IncProfCounter<1> 479 Main: 480 0x11a00030 d2800100 movz x0, #0x8 481 0x11a00034 f2b4f000 movk x0, #0xa780, lsl #16 482 0x11a00038 f2dfffe0 movk x0, #0xffff, lsl #32 483 0x11a0003c c85f7c12 unimplemented (Unimplemented) 484 0x11a00040 f1000652 subs x18, x18, #0x1 (1) 485 0x11a00044 c8127c12 unimplemented (Unimplemented) 486 0x11a00048 35ffffb2 cbnz w18, #-0xc 487 After === (comments added manually) 511 (03) IncProfCounter<1> 512 Main: 513 Closes #7499 Differential Revision: D4202893 Pulled By: mxw fbshipit-source-id: f12cefe8d8a94ffc354e8d9c6fa5ea6378ad7500

Summary: On Aarch64 the loadb/movxbl sequence would generate ldrsb/uxtb. This occurred around the Vinstr cmpbm instructions. It is equivalent to just use the ldrb instruction and save one instruction per instance. Before ==== 14854 0: FPushFuncD 0 "ut_main" 14855 (03) EndGuards 14856 (07) t3:Func = LdFuncCached<ut_main> -> B2<Catch> 14857 Main: 14858 0x296008b0 d28217e0 movz x0, #0x10bf 14859 0x296008b4 38e06b60 ldrsb w0, [x27, x0] // <<--+ 14860 0x296008b8 53001c00 uxtb w0, w0 // <<--+ 14861 0x296008bc d29fffe1 movz x1, #0xffff 14862 0x296008c0 f2a05fe1 movk x1, #0x2ff, lsl #16 14863 0x296008c4 38616b61 ldrb w1, [x27, x1] 14864 0x296008c8 6b00003f cmp w1, w0 After ===== 320 0: FPushFuncD 0 "ut_main" 32 Closes #7593 Differential Revision: D4442877 Pulled By: mxw fbshipit-source-id: 04af9bc4ce61ece185e6fa225b1b12950f0bab58

Summary: This creates an ARMv8 specific Vinstr to represent a commonly used form of the ubfm/ubfx instruction and the peephole to detect it. This pattern was seen in several of the regression tests. It is generated during the lowering of the callm instruction. Before ===== 0x434009c4 53001c21 uxtb w1, w1 0x434009c8 53027c21 lsr w1, w1, #2 0x434009cc d37df021 lsl x1, x1, #3 0x434009d0 d297c302 movz x2, #0xbe18 0x434009d4 f2a1c322 movk x2, #0xe19, lsl #16 0x434009d8 f8626821 ldr x1, [x1, x2] 0x434009dc d63f0020 blr x1 After ===== 0x40400994 53021c21 ubfx w1, w1, #2, #6 0x40400998 d37df021 lsl x1, x1, #3 0x4040099c d2965e02 movz x2, #0xb2f0 0x404009a0 f2a081a2 movk x2, #0x40d, lsl #16 0x404009a4 f8626821 ldr x1, [x1, x2] 0x404009a8 d63f0020 blr x1 This was seen 169 times in hphp/test/quick/all_type_comparison_test.php and 230 times in hphp/test/zend/good/ext/intl/tests/grapheme.php. The standard regression tests were run with 6 option sets. No new regressions seen. Closes #7820 Differential Revision: D5063904 Pulled By: mxw fbshipit-source-id: 7a2fd19e498b09e8d2a01c6bb7abc575aa184727

Summary: This adds a quick pass for ARM targets which attempts to reuse immediate values generated by the ldimmq Vinstr. This pass only operates on single blocks. The span of this optimization is tunable so that it does not increase register pressure. The default for the new option is 8, (-vEval.JitLdimmqSpan=8). Here is an example of the pass firing on test/zend/good/ext/intl/tests/grapheme.php Without ===== 36918 (38) DecRef<-> t7:Str 36919 Main: 36920 0x468005f4 d29ffe40 movz x0, #0xfff2 36921 0x468005f8 f2a05fe0 movk x0, #0x2ff, lsl #16 36922 0x468005fc 78e06b61 ldrsh w1, [x27, x0] 36923 0x46800600 11000421 add w1, w1, #0x1 (1) 36924 0x46800604 78206b61 strh w1, [x27, x0] 36925 0x46800608 d29ffe80 movz x0, #0xfff4 //<<--+ 36926 0x4680060c f2a05fe0 movk x0, #0x2ff, lsl #16 //<<--+ 36927 0x46800610 78e06b61 ldrsh w1, [x27, x0] 36928 0x46800614 11000421 add w1, w1, #0x1 (1) 36929 0x46800618 78206b61 strh w1, [x27, x0] With === 36929 (38) DecRef<-> t7:Str 36930 Main: 36931 0x200005f0 d29ffe40 movz x0, #0xfff2 36932 0x200005f4 f2a05fe0 movk x0, #0x2ff, lsl #16 36933 0x200005f8 78e06b61 ldrsh w1, [x27, x0] 36934 0x200005fc 11000421 add w1, w1, #0x1 (1) 36935 0x20000600 78206b61 strh w1, [x27, x0] 36936 0x20000604 91000800 add x0, x0, #0x2 (2) //<<--- 36937 0x20000608 78e06b61 ldrsh w1, [x27, x0] 36938 0x2000060c 11000421 add w1, w1, #0x1 (1) 36939 0x20000610 78206b61 strh w1, [x27, x0] This was tested by running the regression tests with 6 different option sets. No regressions were introduced. Performance testing is pending. Closes #7637 Differential Revision: D4501447 Pulled By: mxw fbshipit-source-id: 4f08109ddef35da85209b1ae09f40a4181353513

Summary: While examining the log file produced for zend/good/ext/intl/tests/grapheme.php I noticed some code generation that could be improved. There were several thousand add instructions that really didn't contribute. I traced it down to the reuseImmq optimization. If there is no bias, a copy instruction could be generated. This would then later be elided after register allocation. Before ===== ``` (18) DecRef<-> t3:Cell Main: 0x44400284 d29fff02 movz x2, #0xfff8 0x44400288 f2a05fe2 movk x2, #0x2ff, lsl #16 0x4440028c 78626b63 ldrh w3, [x27, x2] 0x44400290 13003c63 sxth w3, w3 0x44400294 3100047f cmn w3, #0x1 (1) 0x44400298 1a9f07e3 cset w3, ne 0x4440029c 91000042 add x2, x2, #0x0 (0) //<<--- 0x444002a0 78626b64 ldrh w4, [x27, x2] 0x444002a4 0b030084 add w4, w4, w3 0x444002a8 78226b64 strh w4, [x27, x2] 0x444002ac 7200003f tst w1, #0x1 ``` After ==== ``` (18) DecRef<-> t3:Cell Main: 0x27000284 d29fff02 movz x2, #0xfff8 0x27000288 f2a05fe2 movk x2, #0x2ff, lsl #16 0x2700028c 78626b63 ldrh w3, [x27, x2] 0x27000290 13003c63 sxth w3, w3 0x27000294 3100047f cmn w3, #0x1 (1) 0x27000298 1a9f07e3 cset w3, ne 0x2700029c 78626b64 ldrh w4, [x27, x2] 0x270002a0 0b030084 add w4, w4, w3 0x270002a4 78226b64 strh w4, [x27, x2] 0x270002a8 7200003f tst w1, #0x1 ``` The standard regression tests were run with 6 option sets. No new issues were seen. Pull Request resolved: #8265 Reviewed By: mofarrell Differential Revision: D9978181 Pulled By: ottoni fbshipit-source-id: d92119a9bf72f27b5a732cc0a396812654e1a1ed

Summary: We have seen deadlock running `terminationHandler` -> `hasSubscribers` in 2 threads. It's unclear which other thread is holding the lock. To make things easier to debug next time, let's change terminationHandler (and also main.cpp) to bypass the logging lock and write to stderr directly. Related threads (all threads in P536343453): Thread 11 (LWP 3275661): #0 syscall () at ../sysdeps/unix/sysv/linux/x86_64/syscall.S:38 #1 0x0000000001cc995b in folly::detail::(anonymous namespace)::nativeFutexWaitImpl (addr=<optimized out>, expected=<optimized out>, absSystemTime=<optimized out>, absSteadyTime=<optimized out>, waitMask=<optimized out>) at fbcode/folly/detail/Futex.cpp:126 #2 folly::detail::futexWaitImpl (futex=0x89, futex@entry=0x7f1c3ac2ef90, expected=994748889, absSystemTime=absSystemTime@entry=0x0, absSteadyTime=<optimized out>, absSteadyTime@entry=0x0, waitMask=waitMask@entry=1) at fbcode/folly/detail/Futex.cpp:254 #3 0x0000000001d34bce in folly::detail::futexWait<std::atomic<unsigned int> > (futex=0x7f1c3ac2ef90, expected=137, waitMask=1) at buck-out/v2/gen/fbcode/110b607930331a92/folly/detail/__futex__/headers/folly/detail/Futex-inl.h:96 #4 folly::SharedMutexImpl<false, void, std::atomic, folly::SharedMutexPolicyDefault>::WaitForever::doWait (this=<optimized out>, futex=..., expected=137, waitMask=1) at buck-out/v2/gen/fbcode/110b607930331a92/folly/__shared_mutex__/headers/folly/SharedMutex.h:718 #5 folly::SharedMutexImpl<false, void, std::atomic, folly::SharedMutexPolicyDefault>::futexWaitForZeroBits<folly::SharedMutexImpl<false, void, std::atomic, folly::SharedMutexPolicyDefault>::WaitForever> (this=0x7f1c3ac2ef90, state=@0x7f1c149f88e4: 118379409, goal=128, waitMask=1, ctx=...) at buck-out/v2/gen/fbcode/110b607930331a92/folly/__shared_mutex__/headers/folly/SharedMutex.h:1184 #6 0x0000000001cd42b2 in folly::SharedMutexImpl<false, void, std::atomic, folly::SharedMutexPolicyDefault>::yieldWaitForZeroBits<folly::SharedMutexImpl<false, void, std::atomic, folly::SharedMutexPolicyDefault>::WaitForever> (this=0x7f1c3ac2ef90, state=@0x7f1c149f88e4: 118379409, goal=128, waitMask=1, ctx=...) at buck-out/v2/gen/fbcode/110b607930331a92/folly/__shared_mutex__/headers/folly/SharedMutex.h:1151 #7 folly::SharedMutexImpl<false, void, std::atomic, folly::SharedMutexPolicyDefault>::waitForZeroBits<folly::SharedMutexImpl<false, void, std::atomic, folly::SharedMutexPolicyDefault>::WaitForever> (this=0x7f1c3ac2ef90, state=@0x7f1c149f88e4: 118379409, goal=128, waitMask=1, ctx=...) at buck-out/v2/gen/fbcode/110b607930331a92/folly/__shared_mutex__/headers/folly/SharedMutex.h:1109 #8 0x0000000001e7e14c in folly::SharedMutexImpl<false, void, std::atomic, folly::SharedMutexPolicyDefault>::lockSharedImpl<folly::SharedMutexImpl<false, void, std::atomic, folly::SharedMutexPolicyDefault>::WaitForever> (this=0x7f1c3ac2ef90, state=@0x7f1c149f88e4: 118379409, token=0x0, ctx=...) at buck-out/v2/gen/fbcode/110b607930331a92/folly/__shared_mutex__/headers/folly/SharedMutex.h:1664 #9 folly::SharedMutexImpl<false, void, std::atomic, folly::SharedMutexPolicyDefault>::lockSharedImpl<folly::SharedMutexImpl<false, void, std::atomic, folly::SharedMutexPolicyDefault>::WaitForever> (this=0x7f1c3ac2ef90, token=0x0, ctx=...) at buck-out/v2/gen/fbcode/110b607930331a92/folly/__shared_mutex__/headers/folly/SharedMutex.h:1356 #10 folly::SharedMutexImpl<false, void, std::atomic, folly::SharedMutexPolicyDefault>::lock_shared (this=0x7f1c3ac2ef90) at buck-out/v2/gen/fbcode/110b607930331a92/folly/__shared_mutex__/headers/folly/SharedMutex.h:495 #11 std::shared_lock<folly::SharedMutexImpl<false, void, std::atomic, folly::SharedMutexPolicyDefault> >::shared_lock (this=<optimized out>, __m=...) at fbcode/third-party-buck/platform010/build/libgcc/include/c++/trunk/shared_mutex:727 #12 0x0000000002d765fd in folly::LockedPtr<folly::Synchronized<watchman::Publisher::state, folly::SharedMutexImpl<false, void, std::atomic, folly::SharedMutexPolicyDefault> > const, folly::detail::SynchronizedLockPolicy<(folly::detail::SynchronizedMutexLevel)2, (folly::detail::SynchronizedMutexMethod)0> >::doLock<folly::SharedMutexImpl<false, void, std::atomic, folly::SharedMutexPolicyDefault>, std::shared_lock<folly::SharedMutexImpl<false, void, std::atomic, folly::SharedMutexPolicyDefault> >, folly::detail::SynchronizedLockPolicy<(folly::detail::SynchronizedMutexLevel)2, (folly::detail::SynchronizedMutexMethod)0>, 0> (mutex=...) at buck-out/v2/gen/fbcode/110b607930331a92/folly/__synchronized__/headers/folly/Synchronized.h:1493 #13 folly::LockedPtr<folly::Synchronized<watchman::Publisher::state, folly::SharedMutexImpl<false, void, std::atomic, folly::SharedMutexPolicyDefault> > const, folly::detail::SynchronizedLockPolicy<(folly::detail::SynchronizedMutexLevel)2, (folly::detail::SynchronizedMutexMethod)0> >::LockedPtr (this=0x7f1c149f8928, parent=<optimized out>) at buck-out/v2/gen/fbcode/110b607930331a92/folly/__synchronized__/headers/folly/Synchronized.h:1272 #14 folly::SynchronizedBase<folly::Synchronized<watchman::Publisher::state, folly::SharedMutexImpl<false, void, std::atomic, folly::SharedMutexPolicyDefault> >, (folly::detail::SynchronizedMutexLevel)2>::rlock (this=<optimized out>) at buck-out/v2/gen/fbcode/110b607930331a92/folly/__synchronized__/headers/folly/Synchronized.h:229 #15 watchman::Publisher::hasSubscribers (this=<optimized out>) at fbcode/watchman/PubSub.cpp:117 #16 0x0000000002eca798 in watchman::Log::log<char const (&) [39], char const*, char const (&) [3]> (this=<optimized out>, level=level@entry=watchman::ABORT, args=..., args=..., args=...) at buck-out/v2/gen/fbcode/110b607930331a92/watchman/__logging__/headers/watchman/Logging.h:42 #17 0x0000000002ec9ba7 in watchman::log<char const (&) [39], char const*, char const (&) [3]> (level=watchman::ABORT, args=..., args=..., args=...) at buck-out/v2/gen/fbcode/110b607930331a92/watchman/__logging__/headers/watchman/Logging.h:121 #18 (anonymous namespace)::terminationHandler () at fbcode/watchman/SignalHandler.cpp:159 #19 0x00007f1c3b0c7b3a in __cxxabiv1::__terminate (handler=<optimized out>) at ../../.././libstdc++-v3/libsupc++/eh_terminate.cc:48 #20 0x00007f1c3b0c7ba5 in std::terminate () at ../../.././libstdc++-v3/libsupc++/eh_terminate.cc:58 #21 0x0000000001c38c8b in __clang_call_terminate () #22 0x0000000003284c9e in folly::detail::terminate_with_<std::runtime_error, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >&> (args=...) at buck-out/v2/gen/fbcode/110b607930331a92/folly/lang/__exception__/headers/folly/lang/Exception.h:93 #23 0x0000000003281bae in folly::terminate_with<std::runtime_error, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >&> (args=...) at buck-out/v2/gen/fbcode/110b607930331a92/folly/lang/__exception__/headers/folly/lang/Exception.h:123 #24 folly::SingletonVault::fireShutdownTimer (this=<optimized out>) at fbcode/folly/Singleton.cpp:499 #25 0x0000000003281ad9 in folly::(anonymous namespace)::fireShutdownSignalHelper (sigval=...) at fbcode/folly/Singleton.cpp:454 #26 0x00007f1c3b42b939 in timer_sigev_thread (arg=<optimized out>) at ../sysdeps/unix/sysv/linux/timer_routines.c:55 #27 0x00007f1c3b41fc0f in start_thread (arg=<optimized out>) at pthread_create.c:434 #28 0x00007f1c3b4b21dc in clone3 () at ../sysdeps/unix/sysv/linux/x86_64/clone3.S:81 ... Thread 1 (LWP 3201992): #0 syscall () at ../sysdeps/unix/sysv/linux/x86_64/syscall.S:38 #1 0x0000000001cc995b in folly::detail::(anonymous namespace)::nativeFutexWaitImpl (addr=<optimized out>, expected=<optimized out>, absSystemTime=<optimized out>, absSteadyTime=<optimized out>, waitMask=<optimized out>) at fbcode/folly/detail/Futex.cpp:126 #2 folly::detail::futexWaitImpl (futex=0x89, futex@entry=0x7f1c3ac2ef90, expected=994748889, absSystemTime=absSystemTime@entry=0x0, absSteadyTime=<optimized out>, absSteadyTime@entry=0x0, waitMask=waitMask@entry=1) at fbcode/folly/detail/Futex.cpp:254 #3 0x0000000001d34bce in folly::detail::futexWait<std::atomic<unsigned int> > (futex=0x7f1c3ac2ef90, expected=137, waitMask=1) at buck-out/v2/gen/fbcode/110b607930331a92/folly/detail/__futex__/headers/folly/detail/Futex-inl.h:96 #4 folly::SharedMutexImpl<false, void, std::atomic, folly::SharedMutexPolicyDefault>::WaitForever::doWait (this=<optimized out>, futex=..., expected=137, waitMask=1) at buck-out/v2/gen/fbcode/110b607930331a92/folly/__shared_mutex__/headers/folly/SharedMutex.h:718 #5 folly::SharedMutexImpl<false, void, std::atomic, folly::SharedMutexPolicyDefault>::futexWaitForZeroBits<folly::SharedMutexImpl<false, void, std::atomic, folly::SharedMutexPolicyDefault>::WaitForever> (this=0x7f1c3ac2ef90, state=@0x7ffd2d5be924: 118379408, goal=128, waitMask=1, ctx=...) at buck-out/v2/gen/fbcode/110b607930331a92/folly/__shared_mutex__/headers/folly/SharedMutex.h:1184 #6 0x0000000001cd42b2 in folly::SharedMutexImpl<false, void, std::atomic, folly::SharedMutexPolicyDefault>::yieldWaitForZeroBits<folly::SharedMutexImpl<false, void, std::atomic, folly::SharedMutexPolicyDefault>::WaitForever> (this=0x7f1c3ac2ef90, state=@0x7ffd2d5be924: 118379408, goal=128, waitMask=1, ctx=...) at buck-out/v2/gen/fbcode/110b607930331a92/folly/__shared_mutex__/headers/folly/SharedMutex.h:1151 #7 folly::SharedMutexImpl<false, void, std::atomic, folly::SharedMutexPolicyDefault>::waitForZeroBits<folly::SharedMutexImpl<false, void, std::atomic, folly::SharedMutexPolicyDefault>::WaitForever> (this=0x7f1c3ac2ef90, state=@0x7ffd2d5be924: 118379408, goal=128, waitMask=1, ctx=...) at buck-out/v2/gen/fbcode/110b607930331a92/folly/__shared_mutex__/headers/folly/SharedMutex.h:1109 #8 0x0000000001e7e14c in folly::SharedMutexImpl<false, void, std::atomic, folly::SharedMutexPolicyDefault>::lockSharedImpl<folly::SharedMutexImpl<false, void, std::atomic, folly::SharedMutexPolicyDefault>::WaitForever> (this=0x7f1c3ac2ef90, state=@0x7ffd2d5be924: 118379408, token=0x0, ctx=...) at buck-out/v2/gen/fbcode/110b607930331a92/folly/__shared_mutex__/headers/folly/SharedMutex.h:1664 #9 folly::SharedMutexImpl<false, void, std::atomic, folly::SharedMutexPolicyDefault>::lockSharedImpl<folly::SharedMutexImpl<false, void, std::atomic, folly::SharedMutexPolicyDefault>::WaitForever> (this=0x7f1c3ac2ef90, token=0x0, ctx=...) at buck-out/v2/gen/fbcode/110b607930331a92/folly/__shared_mutex__/headers/folly/SharedMutex.h:1356 #10 folly::SharedMutexImpl<false, void, std::atomic, folly::SharedMutexPolicyDefault>::lock_shared (this=0x7f1c3ac2ef90) at buck-out/v2/gen/fbcode/110b607930331a92/folly/__shared_mutex__/headers/folly/SharedMutex.h:495 #11 std::shared_lock<folly::SharedMutexImpl<false, void, std::atomic, folly::SharedMutexPolicyDefault> >::shared_lock (this=<optimized out>, __m=...) at fbcode/third-party-buck/platform010/build/libgcc/include/c++/trunk/shared_mutex:727 #12 0x0000000002d765fd in folly::LockedPtr<folly::Synchronized<watchman::Publisher::state, folly::SharedMutexImpl<false, void, std::atomic, folly::SharedMutexPolicyDefault> > const, folly::detail::SynchronizedLockPolicy<(folly::detail::SynchronizedMutexLevel)2, (folly::detail::SynchronizedMutexMethod)0> >::doLock<folly::SharedMutexImpl<false, void, std::atomic, folly::SharedMutexPolicyDefault>, std::shared_lock<folly::SharedMutexImpl<false, void, std::atomic, folly::SharedMutexPolicyDefault> >, folly::detail::SynchronizedLockPolicy<(folly::detail::SynchronizedMutexLevel)2, (folly::detail::SynchronizedMutexMethod)0>, 0> (mutex=...) at buck-out/v2/gen/fbcode/110b607930331a92/folly/__synchronized__/headers/folly/Synchronized.h:1493 #13 folly::LockedPtr<folly::Synchronized<watchman::Publisher::state, folly::SharedMutexImpl<false, void, std::atomic, folly::SharedMutexPolicyDefault> > const, folly::detail::SynchronizedLockPolicy<(folly::detail::SynchronizedMutexLevel)2, (folly::detail::SynchronizedMutexMethod)0> >::LockedPtr (this=0x7ffd2d5be968, parent=<optimized out>) at buck-out/v2/gen/fbcode/110b607930331a92/folly/__synchronized__/headers/folly/Synchronized.h:1272 #14 folly::SynchronizedBase<folly::Synchronized<watchman::Publisher::state, folly::SharedMutexImpl<false, void, std::atomic, folly::SharedMutexPolicyDefault> >, (folly::detail::SynchronizedMutexLevel)2>::rlock (this=<optimized out>) at buck-out/v2/gen/fbcode/110b607930331a92/folly/__synchronized__/headers/folly/Synchronized.h:229 #15 watchman::Publisher::hasSubscribers (this=<optimized out>) at fbcode/watchman/PubSub.cpp:117 #16 0x0000000002ecac20 in watchman::Log::log<char const (&) [59]> (this=<optimized out>, level=level@entry=watchman::ABORT, args=...) at buck-out/v2/gen/fbcode/110b607930331a92/watchman/__logging__/headers/watchman/Logging.h:42 #17 0x0000000002ec9b24 in watchman::log<char const (&) [59]> (level=watchman::ABORT, args=...) at buck-out/v2/gen/fbcode/110b607930331a92/watchman/__logging__/headers/watchman/Logging.h:121 #18 (anonymous namespace)::terminationHandler () at fbcode/watchman/SignalHandler.cpp:165 #19 0x00007f1c3b0c7b3a in __cxxabiv1::__terminate (handler=<optimized out>) at ../../.././libstdc++-v3/libsupc++/eh_terminate.cc:48 #20 0x00007f1c3b0c7ba5 in std::terminate () at ../../.././libstdc++-v3/libsupc++/eh_terminate.cc:58 #21 0x0000000002d8cde1 in std::thread::~thread (this=0x7f1c3ac2ef90) at fbcode/third-party-buck/platform010/build/libgcc/include/c++/trunk/bits/std_thread.h:152 #22 0x00007f1c3b3cc8f8 in __run_exit_handlers (status=1, listp=0x7f1c3b598658 <__exit_funcs>, run_list_atexit=<optimized out>, run_dtors=<optimized out>) at exit.c:113 #23 0x00007f1c3b3cca0a in __GI_exit (status=<optimized out>) at exit.c:143 #24 0x00007f1c3b3b165e in __libc_start_call_main (main=0x2d11220 <main(int, char**)>, argc=2, argv=0x7ffd2d5bec78) at ../sysdeps/nptl/libc_start_call_main.h:74 #25 0x00007f1c3b3b1718 in __libc_start_main_impl (main=0x2d11220 <main(int, char**)>, argc=2, argv=0x7ffd2d5bec78, init=<optimized out>, fini=<optimized out>, rtld_fini=<optimized out>, stack_end=0x7ffd2d5bec68) at ../csu/libc-start.c:409 #26 0x0000000002d0e181 in _start () at ../sysdeps/x86_64/start.S:116 Reviewed By: xavierd Differential Revision: D40166374 fbshipit-source-id: 7017e20234e5e0a9532eb61a63ac49ac0020d443

…ook#16) Summary: X-link: facebook/squangle#16 Rename arguments to fix lint errors Reviewed By: abal147 Differential Revision: D40954426 fbshipit-source-id: 6eb4bb2fe32b119fd8999d273d2b9f9b8903862e

Summary: AsyncUDPSocket test cases are crashing when running under llvm15. During debugging it seems that the issue is the fact that the code tries to allocated 0 size array. Changing the code to prevent such allocation. This is not very clean why to fix, but I am not sure if there is better one. Please let me know if you have any suggestions. Sample crash: ``` $ buck test //folly/io/async/test:async_udp_socket_test ... stdout: Note: Google Test filter = AsyncUDPSocketTest.TestDetachAttach [==========] Running 1 test from 1 test suite. [----------] Global test environment set-up. [----------] 1 test from AsyncUDPSocketTest [ RUN ] AsyncUDPSocketTest.TestDetachAttach stderr: fbcode/folly/io/async/AsyncUDPSocket.cpp:699:10: runtime error: variable length array bound evaluates to non-positive value 0 #0 0x7f4d8ed93704 in folly::AsyncUDPSocket::writev(folly::SocketAddress const&, iovec const*, unsigned long, int) fbcode/folly/io/async/AsyncUDPSocket.cpp:698 #1 0x7f4d8ed9081f in folly::AsyncUDPSocket::writeGSO(folly::SocketAddress const&, std::unique_ptr<folly::IOBuf, std::default_delete<folly::IOBuf>> const&, int) fbcode/folly/io/async/AsyncUDPSocket.cpp:528 #2 0x7f4d8ed900b2 in folly::AsyncUDPSocket::write(folly::SocketAddress const&, std::unique_ptr<folly::IOBuf, std::default_delete<folly::IOBuf>> const&) fbcode/folly/io/async/AsyncUDPSocket.cpp:660 #3 0x350a05 in AsyncUDPSocketTest_TestDetachAttach_Test::TestBody() fbcode/folly/io/async/test/AsyncUDPSocketTest.cpp:914 #4 0x7f4d90dd1ad5 in testing::Test::Run() /home/engshare/third-party2/googletest/1.11.0/src/googletest/googletest/src/gtest.cc:2682:50 #5 0x7f4d90dd1ad5 in testing::Test::Run() /home/engshare/third-party2/googletest/1.11.0/src/googletest/googletest/src/gtest.cc:2672:6 #6 0x7f4d90dd1c64 in testing::TestInfo::Run() /home/engshare/third-party2/googletest/1.11.0/src/googletest/googletest/src/gtest.cc:2861:14 #7 0x7f4d90dd1c64 in testing::TestInfo::Run() /home/engshare/third-party2/googletest/1.11.0/src/googletest/googletest/src/gtest.cc:2833:6 #8 0x7f4d90dd2321 in testing::TestSuite::Run() /home/engshare/third-party2/googletest/1.11.0/src/googletest/googletest/src/gtest.cc:3015:31 #9 0x7f4d90dd2321 in testing::TestSuite::Run() /home/engshare/third-party2/googletest/1.11.0/src/googletest/googletest/src/gtest.cc:2993:6 #10 0x7f4d90dd2b1e in testing::internal::UnitTestImpl::RunAllTests() /home/engshare/third-party2/googletest/1.11.0/src/googletest/googletest/src/gtest.cc:5855:47 #11 0x7f4d90dd1d87 in bool testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) /home/engshare/third-party2/googletest/1.11.0/src/googletest/googletest/src/gtest.cc:2665:29 #12 0x7f4d90dd1d87 in testing::UnitTest::Run() /home/engshare/third-party2/googletest/1.11.0/src/googletest/googletest/src/gtest.cc:5438:55 #13 0x7f4d90d5c990 in RUN_ALL_TESTS() fbcode/third-party-buck/platform010/build/googletest/include/gtest/gtest.h:2490 #14 0x7f4d90d5c618 in main fbcode/common/gtest/LightMain.cpp:20 #15 0x7f4d8ea2c656 in __libc_start_call_main /home/engshare/third-party2/glibc/2.34/src/glibc-2.34/csu/../sysdeps/nptl/libc_start_call_main.h:58:16 #16 0x7f4d8ea2c717 in __libc_start_main@GLIBC_2.2.5 /home/engshare/third-party2/glibc/2.34/src/glibc-2.34/csu/../csu/libc-start.c:409:3 #17 0x33ea60 in _start /home/engshare/third-party2/glibc/2.34/src/glibc-2.34/csu/../sysdeps/x86_64/start.S:116 ... ``` Reviewed By: russoue, dmm-fb Differential Revision: D43858875 fbshipit-source-id: 93749bab17027b6dfc0dbc01b6c183e501a5494c

This was referenced Mar 18, 2013

HHVM incorrect behavior for stream_socket_sendto() #713

Closed

HHVM crashes for preConst during merge/unmerge #720

Closed

Yehonal mentioned this issue Jun 15, 2013

Cannot patch libevent #813

Closed

This was referenced Jul 30, 2013

hhvm crashed with report #899

Closed

is there a way to get the thread state in HHVM? #929

Closed

Kozzi11 mentioned this issue Aug 30, 2013

Random crashes after session_set_save_handler #990

Closed

pedigree mentioned this issue Nov 14, 2013

core dump in fastcgi #1272

Closed

rbelenov mentioned this issue Feb 14, 2014

Uninitialized TLS key is used due to dependencies between static objects #1815

Closed

ptarjan mentioned this issue Feb 25, 2014

Implements double_encode in Htmlspecialchars #1862

Closed

Daniel-ccx mentioned this issue Mar 18, 2014

runtime crash : Program received signal SIGSEGV, Segmentation fault. #2096

Closed

mocanuga mentioned this issue Jun 13, 2014

spl_autoload causes segmentation fault #2932

Closed

This was referenced Jul 28, 2014

Segfault in test hphp/test/quick/reflection_get_closure.php #3295

Closed

assertion on file upload #3296

Closed

segfault after some time of work #3297

Closed

lscgzwd mentioned this issue Aug 25, 2014

Core dumped when file not found #3584

Closed

richardyao mentioned this issue Aug 29, 2014

hhvm-3.0.1 core dump #3620

Closed

rrh mentioned this issue Oct 7, 2014

assertion failed regarding refcounting in test/slow/objprof/strings.php #3920

Closed

andrisi mentioned this issue Oct 16, 2014

Segmentation fault on var_dump() of simplehtmldom object #3991

Closed

ebernhardson mentioned this issue Oct 27, 2014

Crash in FastCGISession::endTransaction #4068

Closed

rootnet mentioned this issue Nov 11, 2014

hhvm in server mode crash on HPHP::jit::HhbcTranslator::MInstrTranslator::getKey #4208

Closed

matzematthaey mentioned this issue Nov 18, 2014

native: mysqli fetch with ssl delivers no results, hhvm crashes #4272

Closed

chrivers mentioned this issue Nov 28, 2014

HHVM crashes in libxml2 - backtrace attached #4350

Closed

dstelter mentioned this issue Feb 18, 2015

high hhvm CPU usage when idle after high usage #2069

Closed

rrh mentioned this issue Mar 13, 2015

test/run failures on OSS Release build on ubuntu 14.04 #5019

Closed

apinski-cavium mentioned this issue Mar 18, 2015

hhvm/hphp/runtime/vm/native.cpp should really be using libffi #5035

Closed

edwh mentioned this issue Jun 4, 2015

HHVM hang in flock below FileSessionData::openImpl #5450

Closed

alex-mashin mentioned this issue Jul 12, 2015

HHVM segfaults while processing MediaWiki 1.25.1 / GeSHi errors #5672

Closed

jaredjones mentioned this issue Jan 25, 2016

hhvm hangs in phpmyadmin with high cpu usage until gateway times out #6429

Closed

ccnie mentioned this issue Apr 1, 2016

3.13 is easy to die, seems caused by log print #6941

Closed

wake-up-neo mentioned this issue May 18, 2016

Threads stuck waiting for CurlMultiAwait [critical] #7076

Closed

jonghorhee mentioned this issue Sep 12, 2016

HHVM 3.15 package for Ubuntu 14.04/16.04 crashes and it is unstable #7333

Closed

gdbentley mentioned this issue Nov 12, 2016

Segfault running oss-performance wordpress #7487

Closed

ptomsich mentioned this issue Jan 13, 2017

Different floating point results with on modern machines (-ffp-contract) #7594

Closed

swalk-cavium mentioned this issue Feb 1, 2017

Pass to reuse ldimmq immediate values #7637

Closed

ProdigyView mentioned this issue Feb 14, 2017

Segmentation Fault #7670

Closed

mmuehlenhoff mentioned this issue Apr 3, 2017

HHVM 3.18.1 deadlocks with stat_cache enabled #7756

Closed

qdore mentioned this issue Aug 9, 2017

sqlite3_clear_bindings core dump #7957

Open

swalk-cavium mentioned this issue Sep 5, 2017

aarch64 - Update gdb python to use ARMv8 registers #7985

Open

ocasta mentioned this issue Nov 2, 2017

Segmentation fault in 3.22.1 #8040

Closed

safe-net9 mentioned this issue Nov 21, 2017

HHVM stops at segmentation fault (mysql_set_charset) #8050

Closed

swalk-cavium mentioned this issue Aug 30, 2018

HHVM 3.28 segmentation fault when talking to Oracle MySQL or MariaDB #8306

Closed

swalk-cavium mentioned this issue Sep 10, 2018

aarch64 - extra sign/zero extension around function calls #8318

Open

swalk-cavium mentioned this issue Mar 21, 2019

full_fidelity_syntax_type.ml no longer builds on Aarch64 hosts #8469

Closed

This issue was closed.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

compile error HPHP::Variant::Variant(ssize_t) cannot be overloaded #16

compile error HPHP::Variant::Variant(ssize_t) cannot be overloaded #16

danielrmz commented Feb 21, 2010

Maeyanie commented Feb 21, 2010

scottmac commented Feb 21, 2010

compile error HPHP::Variant::Variant(ssize_t) cannot be overloaded #16

compile error HPHP::Variant::Variant(ssize_t) cannot be overloaded #16

Comments

danielrmz commented Feb 21, 2010

Maeyanie commented Feb 21, 2010

scottmac commented Feb 21, 2010