Convert ext/standard/class_object to HNI

[simonwelsh]

Also moves get_called_class() out of function and into this, as that's how the PHP docs groups it.

Part of #1480

[scannell]

I'm having issues with this because git keeps stripping the whitepsace when I git pull --rebase with this diff as HEAD which causes tests to fail. I'll pull this once I figure out how to get around that (or let me know if anyone has any ideas what could be wrong.)

[scannell]

Also, please don't modify Zend tests -- if you do for some reason, you need to change the import script.

[simonwelsh]

The Zend test modifications came from running the import script on a recent (last week sometime) pull of PHP-5.5. The only changes I made are also reflected in the import script (some norepo and importing another .inc file)

[scannell]

I'm seeing some weird interaction with fb_intercept in our PHP code -- this is going to take a bit to unravel.

[scannell]

mixed

[simonwelsh]

Bah, another one of those? I'm going to make a script that checks the types match.

[scannell]

Something in this pull is causing a consistent performance regression of about 1%. I'm not sure if it is HNI overhead or what, but we probably won't take this until this is resolved.

[scannell]

Thanks to @jdelong I believe we've identified the source of the regression -- it's not your fault.

The FCallBuiltin logic needs to be fixed to support HNI functions first.
Also, get_defined_functions() needs to be fixed to show HNI functions as well. (The latter might be doable if you want to attempt it in a separate change.)

[simonwelsh]

What's the status of this?

[ptarjan]

I tried to go through this today and rebasing it is an enormous undertaking. I got it to compile but I think I'm doing some wrong things semantically.

I also noticed it was failing some tests in test/zend/good/ext/standard/tests/class_object/ Can you make sure they all pass?

There also seems to be a behavior diff with this. Some of our tests are failing with mocked classes reporting their class as the mocked name instead of the original class.

[simonwelsh]

Rebased. All quick/, zend/good/Zend and zend/good/ext/standard/tests/class_object/ are passing locally. Relies on #2221 for the checker script to pass.

[ptarjan]

This have lots of test failures in class_object still