Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ip2long() doesn't return false for certain invalid IP Addresses #2209

Closed
tjlee0909 opened this issue Mar 27, 2014 · 1 comment
Closed

ip2long() doesn't return false for certain invalid IP Addresses #2209

tjlee0909 opened this issue Mar 27, 2014 · 1 comment
Assignees
@sgolemon
Labels
mid-pri php5 incompatibility

Comments

@tjlee0909
Copy link

In zend php,

$val = ip2long('1');

will have $val set to false. But in HHVM it returns the integer value of 1.
@sgolemon sgolemon self-assigned this Mar 28, 2014
@scannell
Copy link
Contributor

scannell commented Apr 2, 2014

Thanks for reporting this. Feel free to submit a PR if you (or someone else reading this) gets to this before we do.

jeffchan added a commit to jeffchan/hhvm that referenced this issue Apr 3, 2014
@jeffchan
Fix ip2long() behavior to be compatible with PHP5.
cc84d56 
Fixes facebook#2209.
@jeffchan jeffchan mentioned this issue Apr 3, 2014
Closed
@LiraNuna LiraNuna mentioned this issue Apr 23, 2014
Closed
facebook-github-bot pushed a commit that referenced this issue May 22, 2024
@bigfootjon @facebook-github-bot
Fix the way conan is installed (#2209)
a2bee30 
Summary: Pull Request resolved: facebook/folly#2209

Reviewed By: yfeldblum

Differential Revision: D57681379

Pulled By: bigfootjon

fbshipit-source-id: 3db51bc103400bdc5af9ff80aefdb94bf1d87b2d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgolemon sgolemon

Labels
mid-pri php5 incompatibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix ip2long() behavior to be compatible with PHP5. jeffchan/hhvm
3 participants
@sgolemon @tjlee0909 @scannell