Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

incorrect argv name echoed back in error message #2864

Closed
rrh opened this issue Jun 5, 2014 · 3 comments
Closed

incorrect argv name echoed back in error message #2864

rrh opened this issue Jun 5, 2014 · 3 comments
Assignees
@JoelMarcey
Labels
low-pri

Comments

@rrh
Copy link
Contributor

rrh commented Jun 5, 2014

This invocation:
hhvm --xhprof-flags 0x200
Results in this error message:
Error in command line: the argument ('0x200') for option '--flags' is invalid

The name of the flag reported back is wrong. It says '--flags'. It should be '--xhprof-flags'.
@JoelMarcey JoelMarcey self-assigned this Nov 13, 2014
@JoelMarcey
Copy link
Contributor

@rrh Looks like we are using a version of boost (1.54) that does not have the following fix included...

mirror/boost@63055b6

I bet this fix is in 1.55.

I could kludge my away around this maybe within the HHVM code; I can see how easy that is.

@JoelMarcey
Copy link
Contributor

Internal Diff: D1681063

JoelMarcey added a commit that referenced this issue Nov 30, 2014
@JoelMarcey @hhvm-bot
Make options with dashes show correctly on option error.
50ee3f0 
Summary: There is a bug in at least Boost 1.54 where options with dashes `-` in them are
not handled correctly. Basically all but the last substring after the last dash
is returned.

See: #2864

So our error string when an option had an invalid argument was just plain wrong.
Since we can't fix boost very easily and are not planning to upgrade yet, we
workaround it with this fix.

Fixes: #2864

Reviewed By: @paulbiss

Differential Revision: D1681063

Signature: t1:1681063:1416505169:7664cff3c23b8fdfec995c54897eb276d44f92d6
@JoelMarcey
Copy link
Contributor

closed by 50ee3f0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoelMarcey JoelMarcey

Labels
low-pri
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@fredemmott @rrh @JoelMarcey