hphp crash with define statement

[lcastelli]

When defining a constant with a name computed from other constants, hphp crashes during the "inferring types" phase.

This is a minimal PHP file to reproduce the issue:

<?php
define('A', 'B');
define('A_'.A, 'B');
?>

The error:

hphp: /usr/include/boost/shared_ptr.hpp:419: T* boost::shared_ptr<  >::operator->() const [with T = HPHP::BlockScope]: Assertion `px != 0' failed.

And the stack trace:

#0  0x00007ffff3ef14b5 in raise () from /lib/libc.so.6
#1  0x00007ffff3ef4f50 in abort () from /lib/libc.so.6
#2  0x00007ffff3eea481 in __assert_fail () from /lib/libc.so.6
#3  0x000000000084007b in boost::shared_ptr::operator->() const ()
#4  0x000000000085fd11 in HPHP::SimpleFunctionCall::inferAndCheck(boost::shared_ptr, boost::shared_ptr, bool) ()
#5  0x0000000000982bf1 in HPHP::ExpStatement::inferTypes(boost::shared_ptr) ()
#6  0x000000000097fb77 in HPHP::StatementList::inferTypes(boost::shared_ptr) ()
#7  0x000000000096a6b6 in HPHP::MethodStatement::inferTypes(boost::shared_ptr) ()
#8  0x000000000098fefb in HPHP::FunctionStatement::inferTypes(boost::shared_ptr) ()
#9  0x00000000009114be in HPHP::FileScope::inferTypes(boost::shared_ptr) ()
#10 0x00000000008733ca in HPHP::AnalysisResult::inferTypes(int) ()
#11 0x000000000080fd2a in cppTarget(ProgramOptions const&, boost::shared_ptr, bool) ()
#12 0x0000000000810479 in runTargetCheck(ProgramOptions const&, boost::shared_ptr) ()
#13 0x000000000080e792 in process(ProgramOptions const&) ()
#14 0x000000000080bb09 in main ()

[scottmac]

Reported internally to 214543

[scottmac]

Fixed now.