Hooked stream_metadata(..) with chown(..). #4027
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Part of facebook#3687. So far, only chown(..) in user-stream-wrapper has been hooked with stream_metadata(..) function. Similar to commit 1f55a08.
|
This pull request has been imported into Phabricator, and discussion and review of the diff will take place at https://reviews.facebook.net/D25407 |
|
Sorry, closing in favor of #4031 |
hhvm-bot
pushed a commit
that referenced
this pull request
Oct 28, 2014
…and lchgrp Summary: PHP added stream metadata in PHP 5.4 for chmod, chown, chgrp, lchmod and lchgrp. http://php.net/manual/en/streamwrapper.stream-metadata.php Closes #3687. Closes #4027. Closes #4031 Reviewed By: @ptarjan Differential Revision: D1629484 Signature: t1:1629484:1414509316:a2f3ceafa61520133dc25f6d58689e156d1fdad3
| @@ -629,7 +629,7 @@ org\bovigo\vfs\vfsStreamWrapperTestCase::chmod | |||
| org\bovigo\vfs\vfsStreamWrapperTestCase::chmodModifiesPermissions | |||
| F | |||
| org\bovigo\vfs\vfsStreamWrapperTestCase::chownChangesUser | |||
| F | |||
| . | |||
There was a problem hiding this comment.
@kevinxucs: I think I missed this in f87415e, do you want to send PR? Also chgrp (and maybe some other as well?) may be fixed.
There was a problem hiding this comment.
@Majkl578 Almost forgot. Thanks for reminding me of that!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #3687. So far, only chown(..) in user-stream-wrapper has been hooked with stream_metadata(..) function. Similar to commit 1f55a08.
Also passes vfsStream's chownChangesUser test case.