Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open-source idx implementation or remove from hhi #4071

Closed
fredemmott opened this issue Oct 27, 2014 · 6 comments
Closed

Open-source idx implementation or remove from hhi #4071

fredemmott opened this issue Oct 27, 2014 · 6 comments
Assignees
@jwatzman
Labels
hack

Comments

@fredemmott
Copy link
Contributor

eg 1c0fbc7

That change is only safe because idx() happens to be unused now in that subtree - otherwise, that change would have broken the test for anyone other than Facebook.

Should also check for other FBOnly functions

cc @jano, @jwatzman
@jwatzman
Copy link
Contributor

IMO we should make idx a builtin for Hack, not just FB-only. It's so damn useful, and we optimize the hell out if it anyways.

@fredemmott
Copy link
Contributor Author

  • release as HH\idx with autoimpot
  • must still be __Overridable, as eg we need to be able to run Aphront (from Phabricator) with force_hh on

@steelbrain
Copy link
Contributor

bump

@fredemmott
Copy link
Contributor Author

I'll hopefully look at this early next year.

@jwatzman jwatzman assigned jwatzman and unassigned fredemmott May 27, 2015
@jwatzman
Copy link
Contributor

cf. https://reviews.facebook.net/D38985

@jwatzman jwatzman mentioned this issue May 28, 2015
Closed
@jwatzman jwatzman mentioned this issue Jun 5, 2015
Closed
@jwatzman
Copy link
Contributor

jwatzman commented Jun 5, 2015

I have a diff up internally to do this, waiting on some cleanup in FB's frontend to percolate through.

jwatzman added a commit that referenced this issue Jul 10, 2015
@jwatzman
Open source idx
80e5a22 
Summary: There really isn't a compelling reason this should be FB-only,
and it's actually causing problems, since the Hack typechecker has some
knowledge of it. So release it as `\HH\idx`, with auto-import in Hack
files.

Fixes #4071

Reviewed By: @paulbiss

Differential Revision: D2109381
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jwatzman jwatzman

Labels
hack
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@fredemmott @jwatzman @steelbrain