You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Summary:
Pull Request resolved: facebook/flow#8142
previously, `File_url.parse "file:///c%3A/foo/bar"` returned `"c:/foo/bar"` instead of `"c:\foo\bar"`, because `/` and `\` are (generally) interchangeable on Windows.
however, `Sys_utils.realpath` does convert them to `\` (only if the file exists, otherwise it leaves it alone!), which makes it more difficult to compare two paths.
so, we now match `realpath`'s behavior, converting `/` to `\` on Windows.
also, `File_url.create "c:\foo\bar"` returns `"file:///c%3A/foo/bar"` on Windows, but on Linux, `\` is a valid path character and should be escaped, like `"file:///c%3A%5Cfoo%5Cbar"`.
Reviewed By: gabelevi, samwgoldman
Differential Revision: D18024985
fbshipit-source-id: 7fcd0e5c03b30045357f14b133fc94907b231163
HHVM Version
3.24.2
Standalone code, or other way to reproduce the problem
Expected result
Actual result
PHP bug report: https://bugs.php.net/bug.php?id=76032
The text was updated successfully, but these errors were encountered: