Handle UNIX domain sockets correctly in memcache & memcached extensions #2450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Memcache::addServer checks for 'unix://' to determine if the host argument represents is a UNIX domain socket. HHVM's version checked for a leading '/'. * Memcached::addServer checks for a leading '/' to determine if the host argument is a UNIX domain socket. HHVM's version did not handle UNIX domain sockets at all. This patch adds UNIX domain socket support to Memcached::addServer, and it corrects the handling of the host argument in Memcache::addServer. Fixes facebook#1375.
|
@atdt Hi. I have pulled this in for review internally. Thanks! Internal phabricator diff: D1316665 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
represents is a UNIX domain socket. HHVM's version checked for a leading '/'.
argument is a UNIX domain socket. HHVM's version did not handle UNIX domain
sockets at all.
This patch adds UNIX domain socket support to Memcached::addServer, and it
corrects the handling of the host argument in Memcache::addServer.
Fixes #1375.