Fix behavior of Redis client #2874
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because HHVM forces auto_detect_line_ending to be enabled (which is a separate bug), if a CRLF is split across two TCP packets, fgets() is liable to get confused and assume that the stream uses CR line ending. As a result, the return value of Redis::sockReadLine() is liable to have either a trailing CR or a leading LF, both of which are corruptions. This causes the client to throw an exception, complaining of a protocol error. The behavior of fgets() is documented here: http://www.php.net/manual/en/function.fgets.php#101963 The Redis protocol spec affirms that responses terminate with CRLF and are guaranteed not to contain either CR or LF in the response body: http://redis.io/topics/protocol
|
@atdt Hi. I have pulled this in for review. Internal Diff Number: D1370933 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because HHVM forces auto_detect_line_ending to be enabled (which is a separate
bug), if a CRLF is split across two TCP packets, fgets() is liable to get
confused and assume that the stream uses CR line ending. As a result, the
return value of Redis::sockReadLine() is liable to have either a trailing CR or
a leading LF, both of which are corruptions. This causes the client to throw an
exception, complaining of a protocol error.
The behavior of fgets() is documented here:
http://www.php.net/manual/en/function.fgets.php#101963
The Redis protocol spec affirms that responses terminate with CRLF and are
guaranteed not to contain either CR or LF in the response body:
http://redis.io/topics/protocol