Fix for Redis EVAL / EVALSHA #3127
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phpredis casts nil responses to bool(false), whereas HHVM returns NULL for both
false and nil return values. For example:
<?php
$redis = new Redis();
$redis->connect( '127.0.0.1' );
var_dump( $redis->evaluate( 'return' ) );
var_dump( $redis->evaluate( 'return false' ) );
With Zend / phpredis, the output is:
bool(false)
bool(false)
With HHVM, it's:
NULL
NULL
This patch adds a fix and a test.
|
Thanks - this is up for review. FB: D1422528 |
wmfgerrit
pushed a commit
to wikimedia/mediawiki
that referenced
this pull request
Jul 7, 2014
The hhvm redis client returns false instead of null. This caused JobQueueRedis to get stuck in an infinite loop. This works around the difference by catching null as a signal for no more jobs. It can be reverted when facebook/hhvm#3127 is in all versions of hhvm we expect to run MediaWiki. Bug: 67622 Change-Id: I9bbad42f36a80635097b8e0140b48b6492b2f0f5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
phpredis casts nil responses to bool(false), whereas HHVM returns NULL for both
false and nil return values. For example:
With Zend / phpredis, the output is:
With HHVM, it's:
This patch adds a fix and a test.