Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As documented and implemented in PHP PHP, type=0 is internal, and type=1 is for user handlers. This function got it the wrong way around.
This is an untested fix for https://phabricator.wikimedia.org/T89918 . MediaWiki relies on seeing type=1 to know which output buffers it can safely cancel in wfResetOutputBuffers(). When HHVM gives type=0 instead, MediaWiki fails to disable output buffering, and thus hits an OOM when it tries to stream out large output, e.g. a 200MB PDF file in the current test case.