In ob_get_status() fix type key #4868
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been imported into Phabricator, and discussion and review of the diff will take place at https://reviews.facebook.net/D33735 |
tstarling
force-pushed
the
ob_get_status-type
branch
from
c0c3625
to
071ab4a
Compare
As documented and implemented in PHP PHP, type=0 is internal, and type=1 is for user handlers. This function got it the wrong way around. Also reorder the array keys and add keys for chunk_size and buffer_used per their undocumented PHP behaviour. When ob_start() is called without arguments, give type=0 and name="default output handler", matching the PHP behaviour. This gives a minimal diff when zend/bad/tests/output/ob_get_status.php and zend/bad/tests/output/ob_013.php are run. It now only complains about the omission of "flags" and "buffer_size", both of which are implementation details that I don't think should have been included in the PHP output. Make ob_get_status_empty.php into a more specific test for facebook#2690, so that it does not restrict details of the return value of ob_get_status() which are unrelated to that bug.
tstarling
force-pushed
the
ob_get_status-type
branch
from
071ab4a
to
1991eb7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As documented and implemented in PHP PHP, type=0 is internal, and type=1 is for user handlers. This function got it the wrong way around.
This is an untested fix for https://phabricator.wikimedia.org/T89918 . MediaWiki relies on seeing type=1 to know which output buffers it can safely cancel in wfResetOutputBuffers(). When HHVM gives type=0 instead, MediaWiki fails to disable output buffering, and thus hits an OOM when it tries to stream out large output, e.g. a 200MB PDF file in the current test case.