Convert T_HASHBANG to T_INLINE_HTML for token_get_all #5023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been imported into Phabricator, and discussion and review of the diff will take place at https://reviews.facebook.net/D35079 |
... and leave everything else alone. Modifying the mapping constants results in T_HASHBANG being registered as the name for T_INLINE_HTML, which we definitely don't want. Now the change is localized to the token_get_all function only.
legoktm
added a commit
to wikimedia/mediawiki-tools-codesniffer
that referenced
this pull request
Jun 19, 2015
…<3.7 token_get_all() in HHVM >=3.5,<3.7 will interpret a hashbang as T_HASHBANG rather than T_INLINE_HTML like PHP5. This has been fixed upstream in <facebook/hhvm#5023>, but we need to support 3.6.0. Bug: T103119 Change-Id: Iac4745580bae313505af370d6361c800f5587f5a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4810 and #4936 by converting
T_HASHBANGtoT_INLINE_HTMLintoken_get_all()output.