[MSVC] Set default path for libraries under MSVC #6503
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed because, quite simply, expecting a dev to explicitly set all 61 of these variables, and then also disable the 5 extensions as well, is just a bit impractical, and, unless they know how CMake handles dependencies internally, they would only be able to use a single configuration, either debug or release, depending on which specific library they refered to in each variable, because you can't mix debug and release objects with MSVC. This is intended to work with the package of dependencies I've setup [here](https://github.com/Orvid/hhvm/releases/tag/v0.0.1), along the same style as PHP. With this, a dev that has that dependency pack setup correctly only has to set the path to Boost, and, for now at least, UODBC, as it's not auto-detected correctly at the moment.
|
This pull request has been imported into Phabricator, and discussion and review of the diff will take place at https://reviews.facebook.net/D50001 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed because, quite simply, expecting a dev to explicitly set all 61 of these variables, and then also disable the 5 extensions as well, is just a bit impractical, and, unless they know how CMake handles dependencies internally, they would only be able to use a single configuration, either debug or release, depending on which specific library they referred to in each variable, because you can't mix debug and release objects with MSVC.
This is intended to work with the package of dependencies I've setup here, along the same style as PHP.
With this, a dev that has that dependency pack setup correctly only has to set the path to Boost, and, for now at least, UODBC, as it's not auto-detected correctly at the moment. This massively reduces the effort required for a new developer to get HHVM configured for MSVC.