Implement DateTimeImmutable::createFromMutable #6846
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes facebook#6805 Test Plan: zend test
|
This pull request has been imported into Phabricator, and discussion and review of the diff will take place at https://reviews.facebook.net/D54501 |
hhvm-bot
pushed a commit
that referenced
this pull request
Sep 6, 2018
Summary: The Hack project uses some sqlite3 integration which Flow does not use. We introduced NO_SQLITE3 to conditionally compile that stuff for Hack, but the define is granular and Hack changes break Flow builds pretty regularly. This is especially complicated because Flow builds on Windows and Hack doesn't. Now that sqlite3 code is (mostly) untangled from the sharedmem code, it's easier to ignore the entire thing with a big #ifndef block around the sqlite3 code. Pull Request resolved: facebook/flow#6846 Reviewed By: sinancepel Differential Revision: D9659239 Pulled By: samwgoldman fbshipit-source-id: 2a924eab326e8f5123ceb793a564526966ffb404
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6805
Test Plan:
zend test