[AArch64] Correctly calculate stub_size(). #7373
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Additionally refactor extract_spoff() using a lighter-weight instruction decoding approach in keeping with the x86_64 and PPC64 implementations..
ghost
added
mxw
reviewed
Sep 23, 2016
|
|
||
| if (instr->Mask(vixl::AddSubImmediateMask) == vixl::SUB_w_imm || | ||
| instr->Mask(vixl::AddSubImmediateMask) == vixl::SUB_x_imm) | ||
| return FPInvOffset{offBytes / int32_t{sizeof(Cell)}}; |
There was a problem hiding this comment.
Just to be a little more clear - please surround the return statement with braces so it's not a single hanging statement.
There was a problem hiding this comment.
Thanks for that. I was gonna inquire. :-) Will post an update shortly.
|
@dave-estes updated the pull request - view changes - changes since last import |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additionally refactor extract_spoff() using a lighter-weight
instruction decoding approach in keeping with the x86_64 and PPC64
implementations.