Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed projects that do no support HHVM anymore #7853

Closed
wants to merge 1 commit into from

Conversation

fabpot
Copy link
Contributor

@fabpot fabpot commented May 23, 2017

I think it's better to remove projects that do not support HHVM anymore to avoid confusion. Anyway, tested versions are now very old and not maintained anymore, so I don't see the point in keeping them here.

In this PR, I've only removed my projects for which I'm the lead dev.

I think it's better to remove projects that do not support HHVM anymore to avoid confusion. Anyway, tested versions are now very old and not maintained anymore, so I don't see the point in keeping them here.
@fredemmott
Copy link
Contributor

HHVM testing a project does not imply the upsstreqm project supports it; if something says otherwise, that should be changed. This suite is used to check for regressions in HHVMs PHP5 support; state of upstream support or staleness of the version is not relevant to regression testing.

Removing them seems to have little benefit, and will be harmful - increasing the chance that HHVMs PHP support gets worse.

@fredemmott fredemmott closed this May 25, 2017
@hopeseekr
Copy link

This PR is needed, because *WE ARE NOT IN A PHP5 WORLD ANY LONGER.

The HHVM team, and Facebook Corp., need to be galvanized to committing to stay compatible with PHP7 or they need to break all pretenses and start marking Hack Language as its own thing.

Otherwise, once all PHP5 code is collecting dust, relatively soon, all of your and my HHVM efforts will have been in vain!

Hopefully this PR is a wakeup call!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants