Spelling #9005

jsoref · 2022-02-17T12:25:15Z

This PR corrects misspellings identified by the check-spelling action.

The misspellings have been reported at jsoref@e308e3f#commitcomment-66884198

The action reports that the changes in this PR would make it happy: jsoref@dc6a358

Note: this PR does not include the action. If you're interested in running a spell check on every PR and push, that can be offered separately.

I've annotated this PR. I'm happy to drop changes to files, drop specific terms, or split things as requested, although this may take some time.

I normally take efforts to exclude third party directories, but for various reasons I didn't here. I'm quite happy to drop any particular files / directories, just let me know where they live. Also, if there's an upstream for them, I'm generally happy to queue fixes for them.

jsoref

Checkpointing notes.

The initial set of suggestions were made by Google Sheets, but all fault is mine. Some of the corrections are wrong. I'm happy to drop things/split things/...

jsoref · 2022-02-17T12:27:40Z

hphp/runtime/ext/CMakeLists.txt

-set(HRE_LIBARIES)
+set(HRE_LIBRARIES)


Afaict this never worked.

I believe it was trying to talk to:
https://github.com/facebook/hhvm/blob/b9eefdbe5550c8f50e280dce9186b8745125fef6/CMake/EXTFunctions.cmake?q=owner%3Acheck-spelling+HRE_LIBRARIES#L9

jsoref · 2022-02-17T12:28:18Z

CMake/FindlibWatchmanClient.cmake

@@ -1,4 +1,4 @@
-# Finds Watchamn C++ client library
+# Finds Watchman C++ client library


This is a brand (I probably won't flag many of these specifically)

CMake/cotire.cmake

jsoref · 2022-02-17T12:31:08Z

hphp/compiler/package.h

- * Therefore, a package is really toppest entry point for parsing.
+ * Therefore, a package is really topmost entry point for parsing.


I'm hoping this is ok, the replacement is a word, and usually that should be the right thing...

hphp/hack/doc/HIPs/contexts_and_coeffects.md

jsoref · 2022-02-17T14:07:54Z

hphp/runtime/vm/jit/memory-effects.cpp

-     * SP relative offset of the firstin the inlined call.
+     * SP relative offset of the first instruction in the inlined call.


very manual intervention

jsoref · 2022-02-17T14:08:21Z

hphp/runtime/vm/jit/memory-effects.h

- * backtracing. They are currently separated out to avoid pessimizing the loads
+ * backtracking. They are currently separated out to avoid pessimizing the loads


Quite possibly wrong.

jsoref · 2022-02-17T14:12:49Z

hphp/runtime/vm/jit/prof-data.cpp

 void ProfData::addTransProfPrologue(TransID transID, SrcKey sk, int nArgs,
                                    uint32_t asmSize) {
-  m_proflogueDB.emplace(PrologueID{sk.funcID(), nArgs}, transID);
+  m_prologueDB.emplace(PrologueID{sk.funcID(), nArgs}, transID);


This argues I'm at least partially wrong.

I'm not sure what a proflogue could be. If there were Prologue and ProfLog, it'd be a bit easier to understand they are intentionally unrelated items.

jsoref · 2022-02-17T14:14:25Z

hphp/runtime/vm/jit/prof-data.h

   * arguments.  (kInvalidTransID|nullptr) is returned if the prologue is not
   * associated with a TransID.
   */
-  TransID proflogueTransId(const Func* func, int nArgs) const;
+  TransID prologueTransId(const Func* func, int nArgs) const;


This feels like the best argument against proflogue. It's really rare in English to randomly insert an f into the middle of a word....

jsoref · 2022-02-17T14:16:17Z

hphp/runtime/vm/jit/simplify.h

- * After running this pass, the caller must run a manditoryDCE to restore IR
+ * After running this pass, the caller must run a mandatoryDCE to restore IR


This supports my DCE case change earlier.

jsoref · 2022-02-18T00:50:54Z

hphp/runtime/vm/jit/tc-record.cpp

-  // the JIT running in jumpstart seeer mode, don't consider retranslateAll to
+  // the JIT running in jumpstart serdes mode, don't consider retranslateAll to


This was strange. (It definitely wasn't automatic.)

jsoref · 2022-02-18T00:53:21Z

hphp/runtime/vm/jit/vasm-util.cpp

- * This SSA restoration algorithm is based on "Simple and Efficent Construction
+ * This SSA restoration algorithm is based on "Simple and Efficient Construction
 * of Static Single Assignment Form" by Matthias Braun, Sebastian Buchwald,
 * Sebastian Hack, et all (with a few tweaks).


This is the proper title of the book...

hphp/runtime/vm/jit/vasm-util.cpp

hphp/runtime/vm/litstr-table.h

jsoref · 2022-02-18T00:57:36Z

hphp/runtime/vm/unit.cpp

+  // ExecutionContext and the TC may retain references to Classes, so
+  // it is possible for Classes to outlive their Unit.


Class'es would never be right.

jsoref · 2022-02-18T01:01:02Z

hphp/tools/tc-print/tc-print.cpp

-    "bytecode translationc event type. Pass '%s' to get a "
+    "bytecode translation event type. Pass '%s' to get a "


things like this tend to worry me

jsoref · 2022-02-18T01:01:30Z

hphp/util/alloc.cpp

-    // Enable backtracing through PHP frames (t9814472).
+    // Enable backtracking through PHP frames (t9814472).


Probably wrong

hphp/zend/html_tables/generate-html-table.py

jsoref · 2022-02-18T01:05:08Z

hphp/zend/zend-html.cpp

-  nullptr, nullptr, nullptr, nullptr, "there4", "becaus", nullptr, nullptr,
+  nullptr, nullptr, nullptr, nullptr, "there4", "because", nullptr, nullptr,


is becaus a thing?

third-party/README.md

facebook-github-bot · 2022-02-18T06:21:16Z

@Atry has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

hphp/hack/hhi/stdlib/builtins_icu_uchar.hhi

Atry · 2022-02-18T06:27:57Z

We might not want to make API changes even if it's a typo.

Atry · 2022-02-18T18:13:13Z

Because there are many risky changes, like change of API and constant values, this PR can hardly pass CI unless excluding all the risky changes or splitting into small PRs.

jsoref · 2022-02-18T20:18:57Z

Happy to split, just provide a recommendation of how. I'm used to doing such changes over long periods of time.

I could for instance try to only change Docs in one PR, or comments in one PR, or locals in one PR.

Alternatively, I could try to change things on a per directory basis.

facebook-github-bot · 2022-02-21T23:02:58Z

@jsoref has updated the pull request. You must reimport the pull request before landing.

Summary: This is a subset of #9005, it should be easier to review/test/clear while we figure out how to digest the larger PR. Pull Request resolved: #9008 Reviewed By: fredemmott Differential Revision: D34462821 Pulled By: Atry fbshipit-source-id: f1ed6ecb56f9dd2528768adb1567dbcc3d6dae66

facebook-github-bot · 2022-03-24T03:59:30Z

@jsoref has updated the pull request. You must reimport the pull request before landing.

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

facebook-github-bot · 2022-03-24T04:09:45Z

@jsoref has updated the pull request. You must reimport the pull request before landing.

Summary: This is a subset of #9005, it should be easier to review/test/clear Note: while the top level item is `hphp/util`, if a commit overlaps other directories, I'm dropping the commit. By excluding spanning commits, I reduce the risk of missing a related change (these tend to result in build/test failures which are painful) at the slight increase in additional commits for my general series. Pull Request resolved: #9070 Reviewed By: alexeyt Differential Revision: D35826622 Pulled By: Wilfred fbshipit-source-id: 847ab9dd919a85d2f0c545f3361791bce7f78ca9

Summary: This is a subset of #9005, it should be easier to review/test/clear Note: while the top level item is `hphp/runtime/base`, if a commit overlaps other directories, I'm dropping the commit. By excluding spanning commits, I reduce the risk of missing a related change (these tend to result in build/test failures which are painful) at the slight increase in additional commits for my general series. Pull Request resolved: #9071 Reviewed By: vsiles Differential Revision: D35826676 Pulled By: Wilfred fbshipit-source-id: d87d39ad34d93431f10ea8e7928d0604e66e0713

facebook-github-bot added CLA Signed oncall: jit labels Feb 17, 2022

jsoref commented Feb 17, 2022

View reviewed changes

jsoref commented Feb 18, 2022

View reviewed changes

jsoref force-pushed the spelling branch from ffc1974 to 3a4e206 Compare February 18, 2022 02:51

Atry reviewed Feb 18, 2022

View reviewed changes

hphp/hack/hhi/stdlib/builtins_icu_uchar.hhi Outdated Show resolved Hide resolved

jsoref mentioned this pull request Feb 21, 2022

Spelling misc #9008

Closed

jsoref force-pushed the spelling branch from 3a4e206 to e479a12 Compare February 21, 2022 23:02

jsoref force-pushed the spelling branch from e479a12 to a5e598d Compare March 24, 2022 03:59

jsoref added 14 commits March 24, 2022 00:08

spelling: present

7c1de2b

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: preserving

5d259df

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: prevprev

b2c2e8d

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: primitive

ff2ede9

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: printing

35871ec

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: priority

9a52f94

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: private

09dd3a3

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: privileges

5a217a4

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: probabilistic

43162f9

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: process

92dc0f5

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: processable

2fa2f4d

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: produced

d72e6c4

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: profile

880d8c2

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: profiler

0317460

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

jsoref added 18 commits March 24, 2022 00:08

spelling: usable

c2b5216

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: usefulness

a72132f

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: utarget

eee863e

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: utilities

c0dc277

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: utility

f4a2b52

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: variable

2dea3ed

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: variables

00511af

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: variant

046fdf8

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: vey

6055ea5

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: visibility

3b75c50

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: warning

e51694d

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: watchman

513e39d

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: watdcsu

22d7bb6

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: whenever

31b16c2

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: whether

298fc2c

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: wildcard

825cdae

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: will

2a2c640

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: wsignaled

2ee348d

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

jsoref force-pushed the spelling branch from a5e598d to 2ee348d Compare March 24, 2022 04:09

This was referenced Mar 24, 2022

Spelling doc #9042

Closed

Spelling tools #9044

Closed

This was referenced Apr 6, 2022

Spelling zend #9057

Open

Spelling vixl #9058

Open

Spelling system #9059

Open

This was referenced Apr 15, 2022

Spelling util #9070

Closed

Spelling runtime base #9071

Closed

Spelling runtime ext #9072

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Spelling #9005

Spelling #9005

jsoref commented Feb 17, 2022 •

edited

jsoref left a comment

jsoref Feb 17, 2022

jsoref Feb 17, 2022

jsoref Feb 17, 2022

jsoref Feb 17, 2022

jsoref Feb 17, 2022

jsoref Feb 17, 2022

jsoref Feb 17, 2022

jsoref Feb 17, 2022

jsoref Feb 18, 2022

jsoref Feb 18, 2022

jsoref Feb 18, 2022

jsoref Feb 18, 2022

jsoref Feb 18, 2022

jsoref Feb 18, 2022

facebook-github-bot commented Feb 18, 2022

Atry commented Feb 18, 2022

Atry commented Feb 18, 2022

jsoref commented Feb 18, 2022

facebook-github-bot commented Feb 21, 2022

facebook-github-bot commented Mar 24, 2022

facebook-github-bot commented Mar 24, 2022

		@@ -1,4 +1,4 @@
		# Finds Watchamn C++ client library
		# Finds Watchman C++ client library

		* Therefore, a package is really toppest entry point for parsing.
		* Therefore, a package is really topmost entry point for parsing.

		* SP relative offset of the firstin the inlined call.
		* SP relative offset of the first instruction in the inlined call.

		* backtracing. They are currently separated out to avoid pessimizing the loads
		* backtracking. They are currently separated out to avoid pessimizing the loads

		* After running this pass, the caller must run a manditoryDCE to restore IR
		* After running this pass, the caller must run a mandatoryDCE to restore IR

		// the JIT running in jumpstart seeer mode, don't consider retranslateAll to
		// the JIT running in jumpstart serdes mode, don't consider retranslateAll to

		// ExecutionContext and the TC may retain references to Classes, so
		// it is possible for Classes to outlive their Unit.

		"bytecode translationc event type. Pass '%s' to get a "
		"bytecode translation event type. Pass '%s' to get a "

		// Enable backtracing through PHP frames (t9814472).
		// Enable backtracking through PHP frames (t9814472).

		nullptr, nullptr, nullptr, nullptr, "there4", "becaus", nullptr, nullptr,
		nullptr, nullptr, nullptr, nullptr, "there4", "because", nullptr, nullptr,

		set(HRE_LIBARIES)
		set(HRE_LIBRARIES)

Spelling #9005

Are you sure you want to change the base?

Spelling #9005

Conversation

jsoref commented Feb 17, 2022 • edited

jsoref left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

facebook-github-bot commented Feb 18, 2022

Atry commented Feb 18, 2022

Atry commented Feb 18, 2022

jsoref commented Feb 18, 2022

facebook-github-bot commented Feb 21, 2022

facebook-github-bot commented Mar 24, 2022

facebook-github-bot commented Mar 24, 2022

jsoref commented Feb 17, 2022 •

edited