Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use an ssh key to push bot generated commits for pull requests #9255

Closed
wants to merge 10 commits into from

Conversation

Atry
Copy link
Contributor

@Atry Atry commented Oct 13, 2022

#9142 was an attempt to fix #9139 by triggering CI from issue_comment event. However, #9142 is not ideal because it would confuse some internal tools. This PR instead use a ssh key to push bot generated commits for pull requests, so that GitHub Actions can be triggered by the push event.

Test Plan

See test-nix-flake-update and https://github.com/facebook/hhvm/actions/runs/3239568201/jobs/5309102781

@facebook-github-bot
Copy link
Contributor

@Atry has updated the pull request. You must reimport the pull request before landing.

@facebook-github-bot
Copy link
Contributor

@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@Atry has updated the pull request. You must reimport the pull request before landing.

@facebook-github-bot
Copy link
Contributor

@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@Atry has updated the pull request. You must reimport the pull request before landing.

@facebook-github-bot
Copy link
Contributor

@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@Atry has updated the pull request. You must reimport the pull request before landing.

@facebook-github-bot
Copy link
Contributor

@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@Atry has updated the pull request. You must reimport the pull request before landing.

@facebook-github-bot
Copy link
Contributor

@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@Atry has updated the pull request. You must reimport the pull request before landing.

@facebook-github-bot
Copy link
Contributor

@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@Atry has updated the pull request. You must reimport the pull request before landing.

@facebook-github-bot
Copy link
Contributor

@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@Atry has updated the pull request. You must reimport the pull request before landing.

@facebook-github-bot
Copy link
Contributor

@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@Atry Atry changed the title Update nix-flake-update.yml Use ssh key to push bot generated commits for pull requests Oct 13, 2022
@Atry Atry changed the title Use ssh key to push bot generated commits for pull requests Use an ssh key to push bot generated commits for pull requests Oct 13, 2022
@Atry Atry marked this pull request as ready for review October 13, 2022 04:11
@facebook-github-bot
Copy link
Contributor

@Atry has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@Atry has updated the pull request. You must reimport the pull request before landing.

@facebook-github-bot
Copy link
Contributor

@Atry has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Atry added a commit to Atry/hhvm that referenced this pull request Oct 13, 2022
…ook#9255)

Summary:
facebook#9142 was an attempt to fix facebook#9139 by triggering CI from `issue_comment` event. However, facebook#9142 is not ideal because it would confuse some internal tools. This PR instead use a ssh key to push bot generated commits for pull requests, so that GitHub Actions can be triggered by the push event.

- `main-repo-push-key.kms-ciphertext` is copied from https://github.com/hhvm/packaging/blob/80d75fc/aws/main-repo-push-key.kms-ciphertext

Pull Request resolved: facebook#9255

Test Plan: See facebook@test-nix-flake-update and https://github.com/facebook/hhvm/actions/runs/3239568201/jobs/5309102781

Differential Revision: D40331281

Pulled By: Atry

fbshipit-source-id: 3c6124ec74cf8605910d24a9816a4a3657d9ce99
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GitHub Actions are not triggered in pull requests to update Nix dependencies
2 participants