Fix int64 handling sqlite3 #9441
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The extension was using the sqlite3_*_int API, which would truncate 64-bits int to 32-bits on some code paths. The fix is to use the 64-bits API variants constantly throughout the extension. Added a test that manipulates int64 that are not representable as int32 to make sure we handle those correctly.
|
@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@ricklavoie merged this pull request in c9c52ea. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The extension was using the sqlite3_*_int API, which would truncate 64-bits
int to 32-bits on some code paths. The fix is to use the 64-bits API variants
constantly throughout the extension.
Added a test that manipulates int64 that are not
representable as int32 to make sure we handle
those correctly.