Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fbsimctl formula #4

Merged
merged 1 commit into from
Jul 25, 2016
Merged

Conversation

lawrencelomax
Copy link
Contributor

@lawrencelomax lawrencelomax commented Jul 22, 2016

Adds a formula for fbsimctl, a Command Line Interface to the FBSimulatorControl Framework.

  • Make the Formula
  • Update this pull request when v0.0.1 is tagged shortly, update with the SHA of the Zip Archive of the tagged revision.

cc @bhamiltoncx @sdwilsh

@lawrencelomax
Copy link
Contributor Author

Works with the tagged v0.1.0 as well as HEAD.

[lawrencelomax:~/src/FBSimulatorControl] master 1 ± brew install fbsimctl
==> Installing fbsimctl from facebook/fb
==> Downloading https://github.com/facebook/FBSimulatorControl/tarball/v0.1.0
==> Downloading from https://codeload.github.com/facebook/FBSimulatorControl/legacy.tar.gz/v0.1.0
######################################################################## 100.0%
==> ./build.sh cli build /usr/local/Cellar/fbsimctl/0.1.0/libexec
🍺  /usr/local/Cellar/fbsimctl/0.1.0: 554 files, 49.3M, built in 3 minutes 37 seconds
⌂65% [lawrencelomax:~/src/FBSimulatorControl] master 3m39s ± brew remove fbsimctl
Uninstalling /usr/local/Cellar/fbsimctl/0.1.0... (554 files, 49.3M)
[lawrencelomax:~/src/FBSimulatorControl] master ± brew install fbsimctl --HEAD
==> Installing fbsimctl from facebook/fb
==> Cloning https://github.com/facebook/FBSimulatorControl.git
Updating /Users/lawrencelomax/Library/Caches/Homebrew/fbsimctl--git
==> Checking out branch master
==> ./build.sh cli build /usr/local/Cellar/fbsimctl/HEAD-60de2e0/libexec
🍺  /usr/local/Cellar/fbsimctl/HEAD-60de2e0: 554 files, 49.3M, built in 2 minutes 18 seconds


test do
system "fbsimctl", "list"
bin.install_symlink "#{libexec}/xctool"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this in test?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it should install itself as xctool, assuming this is what this means.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I messed this one up! Needs to be symlinked appropriately and but in the build block.

@bhamiltoncx
Copy link
Contributor

Nifty, gave you some thoughts.

@lawrencelomax
Copy link
Contributor Author

Updated so that we will only build in Xcode 7, as the project hasn't migrated to Swift 2.3/Swift 3 yet. Fixed the relevant test & install bits mentioned in the comments.

@bhamiltoncx bhamiltoncx merged commit 0e55764 into facebook:master Jul 25, 2016
@bhamiltoncx
Copy link
Contributor

Looks good, merged.

@lawrencelomax
Copy link
Contributor Author

❤️

@lawrencelomax lawrencelomax deleted the fbsimctl branch July 25, 2016 18:23
@lanzelot1989
Copy link

lanzelot1989 commented Jul 26, 2016

works great, thanks a lot 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants