Skip to content

Commit

Permalink
Don't pass args to xctest cli from test listing
Browse files Browse the repository at this point in the history
Summary: This is wholly un-needed since the arguments are disregarded. Let's make the command as terse as possible

Reviewed By: zeyadsalloum

Differential Revision: D25122978

fbshipit-source-id: 12995c14e9420ae01a7f74b90d62f9b1a2f54861
  • Loading branch information
lawrencelomax authored and facebook-github-bot committed Dec 2, 2020
1 parent f79d95b commit 5e8b386
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions XCTestBootstrap/Configuration/FBXCTestConfiguration.m
Expand Up @@ -311,10 +311,9 @@ - (NSString *)testType
}

NSString *xctestPath = executor.xctestPath;
NSArray<NSString *> *arguments = @[@"-XCTest", @"All", self.testBundlePath];
return [FBXCTestProcess
startWithLaunchPath:xctestPath
arguments:arguments
arguments:@[] // xctest needs no arguments as the shim will disregard & bypass them.
environment:environment
waitForDebugger:NO
stdOutConsumer:stdOutConsumer
Expand Down

0 comments on commit 5e8b386

Please sign in to comment.