Add an option to spawn command in a shell #5340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure what's up with Circle CI. The "restoring cache" step is failing: I've tried amending the last commit, popping a commit off the branch and re-committing fresh, and I'm not having any luck. 😭 |
SimenB
approved these changes
Jan 18, 2018
|
Shouldn't |
seanpoulter
commented
Feb 4, 2018
| ) => ChildProcess, | ||
| testNamePattern?: string, | ||
| testFileNamePattern?: string, | ||
| shell?: boolean, | ||
| }; |
There was a problem hiding this comment.
@stephtr, you're right. These two type definitions have diverged.
https://github.com/facebook/jest/blob/master/packages/jest-editor-support/index.d.ts#L11
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This adds the option to spawn a Jest command in a shell from
jest-editor-support. On Windows, using theshelloption will handle adding the.cmdand.batextensions to thepathToJest.The issue is discussed in jest-community/vscode-jest#98.
Test plan
Unit tests have been added.