-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: replace es2015 with env #5385
Conversation
Because `babel-preset-es2015` is deprecated and `babel-preset-env` is a drop-in replacement.
Codecov Report
@@ Coverage Diff @@
## master #5385 +/- ##
=======================================
Coverage 61.33% 61.33%
=======================================
Files 205 205
Lines 6924 6924
Branches 4 3 -1
=======================================
Hits 4247 4247
Misses 2676 2676
Partials 1 1 Continue to review full report at Codecov.
|
Awesome! Would you mind also replacing it in README.md? https://github.com/facebook/jest#using-babel |
Sure thing! |
Done 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
Note there are still some integration tests using that preset. Perhaps if I think of it later I'll open another PR for it 👍 |
Yup, noticed that, but it's unrelated to PR topic. Much appreciated! |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Because
babel-preset-es2015
is deprecated andbabel-preset-env
is a drop-in replacement.Summary
Replace es2015 with env because
babel-preset-es2015
is deprecated andbabel-preset-env
is a drop-in replacement.Test plan
N/A