Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: replace es2015 with env #5385

Merged
merged 2 commits into from
Jan 24, 2018
Merged

docs: replace es2015 with env #5385

merged 2 commits into from
Jan 24, 2018

Conversation

kentcdodds
Copy link
Contributor

Because babel-preset-es2015 is deprecated and babel-preset-env is a drop-in replacement.

Summary

Replace es2015 with env because babel-preset-es2015 is deprecated and babel-preset-env is a drop-in replacement.

Test plan

N/A

Because `babel-preset-es2015` is deprecated and `babel-preset-env` is a drop-in replacement.
@codecov-io
Copy link

codecov-io commented Jan 24, 2018

Codecov Report

Merging #5385 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5385   +/-   ##
=======================================
  Coverage   61.33%   61.33%           
=======================================
  Files         205      205           
  Lines        6924     6924           
  Branches        4        3    -1     
=======================================
  Hits         4247     4247           
  Misses       2676     2676           
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79086ee...91f4fe7. Read the comment docs.

@thymikee
Copy link
Collaborator

Awesome! Would you mind also replacing it in README.md? https://github.com/facebook/jest#using-babel

@kentcdodds
Copy link
Contributor Author

Sure thing!

@kentcdodds
Copy link
Contributor Author

Done 👍

Copy link
Collaborator

@thymikee thymikee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@kentcdodds
Copy link
Contributor Author

Note there are still some integration tests using that preset. Perhaps if I think of it later I'll open another PR for it 👍

@thymikee
Copy link
Collaborator

Yup, noticed that, but it's unrelated to PR topic. Much appreciated!

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants