Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show suggestion only when unrecognized cli param is longer than 1 character #10604

Merged
merged 1 commit into from
Oct 7, 2020

Conversation

jcs98
Copy link
Contributor

@jcs98 jcs98 commented Oct 7, 2020

Summary

Resolves #9007
Currently running CLI command with an unrecognized parameter of length 1 results in a message containing Did you mean "$0"?

Screenshot from 2020-10-07 17-13-56

Test plan

This fix adds a check to make a suggestion only when the unrecognized cli param length is greater than 1, so that "$0" is not suggested to the user as a possible param

Screenshot from 2020-10-07 18-18-45

Added relevant tests to validateCLIOptions.test.ts

@facebook-github-bot
Copy link
Contributor

Hi @jcs98!

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@jeysal
Copy link
Contributor

jeysal commented Oct 7, 2020

Hi and thanks a lot for the awesome first contribution!
Could you add a quick test for the > 1 and <= 1 cases please? There should already be a validateCLIOptions.test.ts or so :)

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@jcs98 jcs98 changed the title Show suggestion only when unrecognized cli param length is greater than 1 Show suggestion only when unrecognized cli param is longer than 1 character Oct 7, 2020
@jeysal jeysal merged commit 285e462 into jestjs:master Oct 7, 2020
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Running CLI command with "-U" results in a message containing Did you mean "$0"
4 participants