-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show suggestion only when unrecognized cli param is longer than 1 character #10604
Conversation
Hi @jcs98! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
72585a4
to
f742c33
Compare
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
Hi and thanks a lot for the awesome first contribution! |
f742c33
to
bde2fd8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
bde2fd8
to
293752d
Compare
293752d
to
fac872b
Compare
fac872b
to
ee07d7e
Compare
ee07d7e
to
090e547
Compare
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Resolves #9007
Currently running CLI command with an unrecognized parameter of length 1 results in a message containing
Did you mean "$0"?
Test plan
This fix adds a check to make a suggestion only when the unrecognized cli param length is greater than 1, so that
"$0"
is not suggested to the user as a possible paramAdded relevant tests to
validateCLIOptions.test.ts