Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove testURL option, can be set in testEnvironmentOptions #10797

Merged
merged 18 commits into from Feb 23, 2022

Conversation

anje123
Copy link
Contributor

@anje123 anje123 commented Nov 9, 2020

Summary

this is part of the fixes for this issue #7185 , removal of testURL

Test plan

Existing tests.

CHANGELOG.md Outdated Show resolved Hide resolved
packages/jest-types/src/Config.ts Outdated Show resolved Hide resolved
SimenB
SimenB approved these changes Nov 10, 2020
CHANGELOG.md Outdated Show resolved Hide resolved
packages/jest-config/src/normalize.ts Outdated Show resolved Hide resolved
@SimenB SimenB added this to the Jest 28 milestone Feb 23, 2022
@SimenB SimenB changed the title remove testURL option use can be set in "testEnvironmentOptions remove testURL option can be set in testEnvironmentOptions Feb 23, 2022
SimenB
SimenB approved these changes Feb 23, 2022
Copy link
Collaborator

@SimenB SimenB left a comment

Fitting to remove this when we stop shipping jsdom by default in Jest 28. Thanks @anje123!

@@ -49,7 +49,7 @@ export default class JSDOMEnvironment implements JestEnvironment<number> {
})
: undefined,
runScripts: 'dangerously',
url: projectConfig.testURL,
url: 'http://localhost/',
Copy link
Collaborator

@SimenB SimenB Feb 23, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this keeps our current default

@SimenB SimenB changed the title remove testURL option can be set in testEnvironmentOptions feat: remove testURL option, can be set in testEnvironmentOptions Feb 23, 2022
@SimenB SimenB merged commit 0523bcc into facebook:main Feb 23, 2022
24 of 26 checks passed
@SimenB SimenB deleted the remove-testURL branch Feb 23, 2022
@github-actions
Copy link

github-actions bot commented Mar 26, 2022

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants