-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(expect): add asymmetric matcher expect.closeTo
#12243
Conversation
expect.closeTo
Codecov Report
@@ Coverage Diff @@
## main #12243 +/- ##
==========================================
+ Coverage 67.52% 67.55% +0.02%
==========================================
Files 328 328
Lines 17244 17272 +28
Branches 5069 5077 +8
==========================================
+ Hits 11644 11668 +24
- Misses 5567 5571 +4
Partials 33 33
Continue to review full report at Codecov.
|
@SimenB i am excited for this one to land, looking forward to your feedback |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
works for me! normally we wouldn't add more matchers, but this is just an asymmetric version of a matcher we already have.
can you add a changelog entry?
sure |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
expect.closeTo
expect.closeTo
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
added feature for #12242
also added a test for the same in
packages/expect/src/__tests__/asymmetricMatchers.test.ts