Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jest-environment-node: add atob and btoa #12269

Merged
merged 4 commits into from
Jan 28, 2022
Merged

jest-environment-node: add atob and btoa #12269

merged 4 commits into from
Jan 28, 2022

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Jan 27, 2022

Summary

atob and btoa are available as globals since Node.js 16.0.0, I think Jest should leave them available as well.

Fixes: #12268

Test plan

Does this need tests?

@facebook-github-bot
Copy link
Contributor

Hi @aduh95!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@@ -82,6 +82,13 @@ class NodeEnvironment implements JestEnvironment<Timer> {
if (typeof performance !== 'undefined') {
global.performance = performance;
}
if (
typeof atob !== 'undefined' &&
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add a comment here that it is available in node 16 like it was done above?

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

Does this need tests?

nah 😀

@codecov-commenter
Copy link

Codecov Report

Merging #12269 (55c9a75) into main (5f71f86) will decrease coverage by 0.00%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #12269      +/-   ##
==========================================
- Coverage   67.51%   67.51%   -0.01%     
==========================================
  Files         328      328              
  Lines       17246    17249       +3     
  Branches     5071     5072       +1     
==========================================
+ Hits        11643    11645       +2     
- Misses       5570     5571       +1     
  Partials       33       33              
Impacted Files Coverage Δ
packages/jest-environment-node/src/index.ts 61.01% <33.33%> (-1.49%) ⬇️
packages/expect/src/utils.ts 96.53% <0.00%> (+0.49%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f71f86...55c9a75. Read the comment docs.

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 28, 2022
@aduh95 aduh95 deleted the patch-1 branch February 28, 2022 00:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: atob is not defined
5 participants