Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade to JSDOM 19 #12290

Merged
merged 3 commits into from Feb 10, 2022
Merged

feat: upgrade to JSDOM 19 #12290

merged 3 commits into from Feb 10, 2022

Conversation

marcelltoth
Copy link
Contributor

@marcelltoth marcelltoth commented Feb 2, 2022

Resolves #12023

Summary

Bumps JSDOM to 19. See #12023 for details.

As this is a breaking change this should go into Jest 28, not before.

Test plan

Green CI?

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Feb 2, 2022

Hi @marcelltoth!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@SimenB SimenB added this to the Jest 28 milestone Feb 2, 2022
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Feb 2, 2022

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@marcelltoth
Copy link
Contributor Author

marcelltoth commented Feb 2, 2022

Node 10 failures are expected as JSDOM dropped support for it (and 15) because they are EOL.

Won't be a factor as Jest 28 will also drop Node 10/15 support anyway, see #12220

@SimenB
Copy link
Collaborator

SimenB commented Feb 10, 2022

Hey @marcelltoth, and thanks for the PR! Could you resolve the conflicts? 🙂

@marcelltoth
Copy link
Contributor Author

marcelltoth commented Feb 10, 2022

Hi @SimenB no problem! I rebased it and resolved all conflicts, should pass now.

@SimenB SimenB changed the title Upgrade to JSDOM 19 feat: upgrade to JSDOM 19 Feb 10, 2022
@SimenB SimenB merged commit 4255241 into facebook:main Feb 10, 2022
26 checks passed
@codecov-commenter
Copy link

codecov-commenter commented Feb 10, 2022

Codecov Report

Merging #12290 (5693212) into main (a651b65) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #12290   +/-   ##
=======================================
  Coverage   66.94%   66.94%           
=======================================
  Files         329      329           
  Lines       17345    17345           
  Branches     5059     5059           
=======================================
  Hits        11612    11612           
  Misses       5701     5701           
  Partials       32       32           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a651b65...5693212. Read the comment docs.

@marcelltoth marcelltoth deleted the jsdom-19 branch Feb 10, 2022
@github-actions
Copy link

github-actions bot commented Mar 13, 2022

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Bump JSDOM
4 participants