Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(expect): add missing dependency jest-util #12744

Merged
merged 5 commits into from Apr 26, 2022

Conversation

merceyz
Copy link
Contributor

@merceyz merceyz commented Apr 25, 2022

Summary

expect depends on jest-util but doesn't declare it as a dependency.

import {pluralize} from 'jest-util';

Fixes https://github.com/yarnpkg/berry/runs/6157024113?check_suite_focus=true#step:4:44

Test plan

yarn init -2
yarn add jest@^28
  
echo "it('should pass', () => { expect(true).toBeTruthy(); });" | tee pass.test.js
yarn jest pass.test.js

@merceyz merceyz force-pushed the merceyz/fix/expect-missing-dep branch from aceeaba to c437289 Compare Apr 25, 2022
@SimenB
Copy link
Collaborator

SimenB commented Apr 25, 2022

Good catch! Mind updating tsconfig.json as well?

EDIT: hah, good timing 😅

@SimenB
Copy link
Collaborator

SimenB commented Apr 26, 2022

@merceyz any idea why it's failing? It's the PnP test

@merceyz
Copy link
Contributor Author

merceyz commented Apr 26, 2022

Looks like an issue with the npm registry, you can try re-running the failed workflow.

SimenB
SimenB approved these changes Apr 26, 2022
Copy link
Collaborator

@SimenB SimenB left a comment

thanks!

@SimenB SimenB merged commit 9fc3ba4 into facebook:main Apr 26, 2022
88 of 89 checks passed
@merceyz merceyz deleted the merceyz/fix/expect-missing-dep branch Apr 26, 2022
@SimenB
Copy link
Collaborator

SimenB commented Apr 26, 2022

https://github.com/facebook/jest/releases/tag/v28.0.1

F3n67u pushed a commit to F3n67u/jest that referenced this pull request May 2, 2022
@github-actions
Copy link

github-actions bot commented May 27, 2022

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants