Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(jest-resolve): replace process.versions.pnp type declaration with @types/pnpapi devDependency #12783

Merged
merged 5 commits into from
Apr 30, 2022
Merged

chore(jest-resolve): replace process.versions.pnp type declaration with @types/pnpapi devDependency #12783

merged 5 commits into from
Apr 30, 2022

Conversation

mrazauskas
Copy link
Contributor

Closes #10617

Summary

Found by chance and can’t explain why this works. Simply changing export const into export function solves the issue caused by @types/pnpapi. Probably tsc is interpreting export declare const and export declare function somehow differently 🤷‍♂️

Test plan

Green CI.

@mrazauskas mrazauskas changed the title feat(jest-resolve): replace declare global with @types/pnpapi devDependency chore(jest-resolve): replace declare global with @types/pnpapi devDependency Apr 30, 2022
@mrazauskas mrazauskas changed the title chore(jest-resolve): replace declare global with @types/pnpapi devDependency chore(jest-resolve): replace process.versions.pnp type declaration with @types/pnpapi devDependency Apr 30, 2022
CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

huh, weird! I prefer export function anyways, so happy about this 👍

@SimenB SimenB merged commit 48f3d81 into jestjs:main Apr 30, 2022
@mrazauskas mrazauskas deleted the feat-add-@types-pnpapi branch April 30, 2022 10:56
F3n67u pushed a commit to F3n67u/jest that referenced this pull request May 2, 2022
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants