Skip node resolution only for non-relative requires. #2976
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
@voideanvalue and I talked about this about six months ago but I never got to it. Basically we have a lot of "missing" modules because of our PHP JS modules at FB and every resolution of "MyModule" is really slow (there are thousands). However, we can still resolve relative requires quickly. This change skips likely node modules but keeps resolving relative requires without a noticeable performance hit.
Test plan
At FB, this now takes 5 seconds instead of 70.