[lifecycle hooks] Make afterAll hooks operate in the fashion as afterEach. #3275
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks! If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact cla@fb.com if you have any questions. |
gdborton
force-pushed
the
lifecycle-order
branch
from
1cc4d53
to
ffa32ed
Compare
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
…Each. It was discovered that afterAll hooks run in the same order that you add them, while afterEach hooks were running in reverse order. This commit makes their order consistent, and adds regression tests. Relevant issue - jestjs#3268
gdborton
force-pushed
the
lifecycle-order
branch
from
ffa32ed
to
90524e9
Compare
|
Is the order of |
|
@wtgtybhertgeghgtwtg Yep, |
|
@cpojer Have a sec to look at this? Jasmine pulled in the equivalent PR yesterday. |
|
Thanks! |
…Each. (jestjs#3275) It was discovered that afterAll hooks run in the same order that you add them, while afterEach hooks were running in reverse order. This commit makes their order consistent, and adds regression tests. Relevant issue - jestjs#3268
…Each. (jestjs#3275) It was discovered that afterAll hooks run in the same order that you add them, while afterEach hooks were running in reverse order. This commit makes their order consistent, and adds regression tests. Relevant issue - jestjs#3268
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
It was discovered that afterAll hooks run in the same order that you add them,
while afterEach hooks were running in reverse order. This commit makes their
order consistent, and adds regression tests.
Relevant issue - #3268
Note that even if this test were failing, it occurs in an afterAll hook which doesn't currently fail w/ errors.
Test plan
I added tests in the relevant package and tested with a combination of
yarn run buildandyarn run jest ./packages/jest-jasmine2/src/__tests__/integration.The new tests were adapted from a similar set of tests in Jasmine.