Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct summary message for flag --findRelatedTests. #4309

Merged
merged 1 commit into from
Aug 21, 2017

Conversation

tushardhole
Copy link
Contributor

* fixes #4247
* added tests for findRelatedTests summary message

Summary
This fixes the summary message and was reported in 4247.

Test plan

  1. yarn run build && yarn run test was passing

Assumptions

  1. findRelatedTests can be used only when path pattern is present in args
  2. if findRelatedTests is not present and path pattern is provided in args, then the summary message will always be like,
    Ran all test suites matching a.js
  3. findRelatedTests & onlyChanged can not be used together
  4. onlyChanged can not be used when path pattern is present in command

	* fixes jestjs#4247
	* added tests for findRelatedTests summary message
@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@tushardhole
Copy link
Contributor Author

@thymikee Could you please help me understand why things are failing on CI.

  1. AppVeyor | locally node ./scripts/build.js is passing but same is failing here
  2. test-and-deploy-website | not able to get some clue from the console
  3. continuous-integration/travis-ci/pr | yarn run test-ci-partial is passing locally

@thymikee
Copy link
Collaborator

@tushardhole these are unrelated, so don't worry. We're just having some issues with CI servers you mentioned.

@aaronabramov
Copy link
Contributor

looks good to me! thanks @tushardhole

@aaronabramov aaronabramov merged commit cb6bcba into jestjs:master Aug 21, 2017
@tushardhole tushardhole deleted the 4247_fix_PR branch August 23, 2017 08:17
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants