Highlight only last of odd length leading spaces in jest-diff #4558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4558 +/- ##
=======================================
Coverage 56.16% 56.16%
=======================================
Files 185 185
Lines 6285 6285
Branches 3 3
=======================================
Hits 3530 3530
Misses 2754 2754
Partials 1 1
Continue to review full report at Codecov.
|
|
Nice fix! |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Original goal was to see if text node following element does or doesn’t have a leading space.
What if multiple leading spaces? Oops :(
preelement.Baseline before this PR at left and improved from this PR at right:
By the way, visually unexpected indentation of first line of text because child of
preelement.Caused me to learn more than I wanted to know about regex in replace.
Test plan
Added a snapshot test to specify intended (ha ha, misspelled as indented :) behavior.
Aha, it is possible to use snapshots to fail at first, and then update to improved result.