Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

diff-sequences: Double-check number of differences in tests #6953

Merged
merged 3 commits into from
Sep 9, 2018

Conversation

pedrottimark
Copy link
Contributor

Summary

To increase confidence in such a complex algorithm, call a simpler baseline algorithm to compute the number of differences between sequences independently in many of the tests.

Test plan

The new criterion passes for the existing tests which use it.

By the way, it finally hit me that history of changes to files in repo might be better fuzz inputs to diff algorithm than anything I could generate. So offline, I compared number of differences from complex to simpler algorithms for 10306 files in the 2000 commits going back in history from Jest 23.5.0 Ha ha, image files were fuzzier than I wanted, so filtered to js, json, md, and snap files.

@codecov-io
Copy link

codecov-io commented Sep 7, 2018

Codecov Report

Merging #6953 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6953   +/-   ##
=======================================
  Coverage   66.97%   66.97%           
=======================================
  Files         250      250           
  Lines       10379    10379           
  Branches        4        3    -1     
=======================================
  Hits         6951     6951           
  Misses       3427     3427           
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38f445a...75c03c3. Read the comment docs.

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More tests are always good 🙂

@SimenB SimenB merged commit 025c6af into jestjs:master Sep 9, 2018
@pedrottimark pedrottimark deleted the diff-sequences-tests branch September 9, 2018 16:16
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants