fix: add option to disable worker_threads in jest-worker
#7681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattphillips
approved these changes
Jan 22, 2019
|
|
cpojer
approved these changes
Jan 23, 2019
|
Let's get rid of this option once worker threads are known to be stable. |
|
I think it's fair to remove it once Node promotes it from experimental status (it's still experimental even though it's unflagged). However, as discussed, I'll swap this so it's opt-in rather than opt-out |
captain-yossarian
pushed a commit
to captain-yossarian/jest
that referenced
this pull request
Jul 18, 2019
…7681) * fix: add option to disable `worker_threads` in `jest-worker` * link to PR
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
There are certain issues around
worker_threads(notably missingprocess.umask, which makes a few dependencies throw). While these issues are getting fixed (npm/write-file-atomic#37 & nodejs/node#25526) I think we should be on the safe side with Jest 24 and wait for the dust to settle before using it in Jest.However, the default behavior is still to use it if available, this PR explicitly disables it in the places we use
jest-workerinternally.EDIT: Follow-up making it opt-in: #7693
Test plan
Unit test added. This should also fix CI for node 11.