Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Fix circular references in iterable equality" #8259

Closed

Conversation

scotthovestadt
Copy link
Contributor

Summary

Before re-merging the PR, we need to ensure the following test is added and passes:

test('returns false when given inequal set within a map', () => {
  expect(
    iterableEquality(
      new Map([['one', new Set([2])]]),
      new Map([['one', new Set([1, 2])]]),
    ),
  ).toBe(false);
});

I was able to isolate the cause of issues we are seeing to the following simple test case above. I see that the iterableEquality function itself is returning false, but it's getting swallowed somewhere in jasmineUtils eq and returning true regardless.

Hopefully can re-merge for the next release.

FYI @mattphillips

Test plan

  • Revert PR and all related tests. Ensured revert solved the issue seen above.

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants