Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update TestingFrameworks.md #8363

Merged
merged 4 commits into from
Apr 23, 2019
Merged

Update TestingFrameworks.md #8363

merged 4 commits into from
Apr 23, 2019

Conversation

ryanrw
Copy link
Contributor

@ryanrw ryanrw commented Apr 23, 2019

Summary

I added GatsbyJS test with Jest link for someone who visited this page and want to learn more about how GatsbyJS and Jest work.

Test plan

No test need for this edited.

I added GatsbyJS test with Jest link for someone who visited this page and want to learn more about how GatsbyJS and Jest work.
@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@codecov-io
Copy link

codecov-io commented Apr 23, 2019

Codecov Report

Merging #8363 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #8363   +/-   ##
=======================================
  Coverage   62.27%   62.27%           
=======================================
  Files         266      266           
  Lines       10728    10728           
  Branches     2609     2608    -1     
=======================================
  Hits         6681     6681           
  Misses       3462     3462           
  Partials      585      585

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e1e3f8...7945ad5. Read the comment docs.

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Could you also update the versioned docs?

image

@SimenB SimenB merged commit 96546d7 into jestjs:master Apr 23, 2019
@ryanrw
Copy link
Contributor Author

ryanrw commented Apr 23, 2019

@SimenB Thanks for your help with this pull req.

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants